graygelf icon indicating copy to clipboard operation
graygelf copied to clipboard

Installation stucks in endless loop

Open megastef opened this issue 7 years ago • 2 comments

Graygelf depends on microtime, which stucks in an endless loop during package installation with node 8.

See: https://github.com/wadey/node-microtime/issues/55

megastef avatar Jan 31 '18 10:01 megastef

Would you accept a PR, which removes microtime dependency from graygelf?

I think something like this should work without native dependency:

var hrTime = process.hrtime()
var timestampInMicros = hrTime[0] * 1000000 + hrTime[1] / 1000)

megastef avatar Feb 01 '18 21:02 megastef

I don't know enough about hrtime to say either way but it would appear this comment still is relevant:

https://github.com/wadey/node-microtime/pull/16#issuecomment-29836878

I also run Node 8 and I cannot duplicate your issue:

> ~/Projects
19:21 $ mkdir test
> ~/Projects
19:21 $ cd test
> ~/Projects/test
19:21 $ node -v
v8.9.4
> ~/Projects/test
19:21 $ npm init -y
Wrote to /Users/wavded/Projects/test/package.json:

{
  "name": "test",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [],
  "author": "",
  "license": "ISC"
}


> ~/Projects/test
19:21 $ npm install graygelf

> [email protected] install /Users/wavded/Projects/test/node_modules/microtime
> prebuild-install || node-gyp rebuild

prebuild-install info begin Prebuild-install version 2.5.0
prebuild-install info looking for local prebuild @ prebuilds/microtime-v2.1.7-node-v57-darwin-x64.tar.gz
prebuild-install info looking for cached prebuild @ /Users/wavded/.npm/_prebuilds/https-github.com-wadey-node-microtime-releases-download-v2.1.7-microtime-v2.1.7-node-v57-darwin-x64.tar.gz
prebuild-install info found cached prebuild
prebuild-install info unpacking @ /Users/wavded/.npm/_prebuilds/https-github.com-wadey-node-microtime-releases-download-v2.1.7-microtime-v2.1.7-node-v57-darwin-x64.tar.gz
prebuild-install info unpack resolved to /Users/wavded/Projects/test/node_modules/microtime/build/Release/microtime.node
prebuild-install info unpack required /Users/wavded/Projects/test/node_modules/microtime/build/Release/microtime.node successfully
prebuild-install info install Successfully installed prebuilt binary!
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN [email protected] No description
npm WARN [email protected] No repository field.

+ [email protected]
added 58 packages in 2.643s
> ~/Projects/test
19:21 $

I also tried with yarn and didn't have any issues so not sure what's going on perhaps something was fixed upstream since I tested?

wavded avatar Feb 02 '18 01:02 wavded