drunker icon indicating copy to clipboard operation
drunker copied to clipboard

VPC Config Support

Open mcblair opened this issue 6 years ago • 2 comments

Does drunker have the ability to specify subnets or VPC id?

mcblair avatar Apr 11 '18 18:04 mcblair

Now, drunker can't specify it. However, I'd like to add this feature. If you have a patch, please send it. I'll review your pull request :)

wata727 avatar Apr 12 '18 06:04 wata727

Unfortunately I don't have any Ruby experience. I took some time to understand drunker's consumption of the Ruby SDK for AWS and I think I could get it to work - I don't think I can write acceptable tests for the additional parameters.

I'm working directly with AWS Codebuild now(more work than drunker) because I needed VPC access yesterday.

I may submit a PR if I have time and you feel like guiding me on the tests.

mcblair avatar Apr 12 '18 13:04 mcblair