David May

Results 15 comments of David May

@plyr4 do you like it enough for it to be a linter rule that will _gently_ remind folks that their import order might be ... out of order? golangci-lint does...

example stacktraces ``` panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x15af98e] goroutine 1 [running]: github.com/go-vela/sdk-go/vela.(*Client).addAuthentication(0xc00021fb80, 0xc000110900) /home/runner/go/pkg/mod/github.com/go-vela/[email protected]/vela/client.go:215 +0x12e github.com/go-vela/sdk-go/vela.(*Client).NewRequest(0xc00021fb80, {0x2c664ba, 0x4},...

Hey @Gradsta, sorry for not moving on this sooner. First, thanks for making the edits per Easton's callouts. We are still interested in this change. Unfortunately, we aren't able to...

going to move this into draft for now to avoid confusion on this being ready.

Getting back to this PR. What are the thoughts with byte-chunks being out of the picture now? I think the issue should be less pronounced but likely not eliminated, so...

thanks for your interest. it's not on the roadmap currently, but generally speaking we would love to support more SCM providers and we've tried to build it to allow for...

just leaving a note: there is a case to be made to be more restrictive and only allow caching (build and restore) from within the build workspace as `vela/parameters` and...

6a. - define "corporate standard" 5. Migration - should we call out documentation separately? ie. who will create/maintain onboarding, contributing docs for new stack > Do we want to clarify...

6c. - "If we lost 2-3 engineers", without context these numbers don't have a whole lot of meaning, should we generalize this in some way?