wasp icon indicating copy to clipboard operation
wasp copied to clipboard

Replace the `png` Wasp logo with an `svg` in default template

Open infomiho opened this issue 2 years ago • 7 comments

With every new Wasp project we put a png Wasp logo which is 25kB and the equivalent svg file is only 4kB.

Also, the SVG logo works on every resolution and that's kinda the standard nowadays. Small improvement, but it's a cool one.

Implementation

The logo lives in the waspc/data/Cli/templates/basic/src/client/waspLogo.png

The change should:

  1. Swap out the PNG logo with a SVG one (ideally the SVG one would be a React component https://react-svgr.com/playground/)
  2. Test out that the new template works as expected
  3. Fix e2e tests

infomiho avatar Oct 25 '23 09:10 infomiho

wasp-logo-no-border

infomiho avatar Oct 25 '23 09:10 infomiho

Hello Team I want to work on this issue please assign to me

lalitkumawat1m avatar Oct 25 '23 11:10 lalitkumawat1m

I've assigned you. The most important part will be testing it locally to make sure the template works as expected.

infomiho avatar Oct 25 '23 12:10 infomiho

Can I work on it too?

btwshivam avatar Oct 25 '23 19:10 btwshivam

There is no need for two people to work on this issue, so not at the moment.

If @lalitkumawat1m drops it, you can take over, sure.

infomiho avatar Oct 25 '23 19:10 infomiho

Hey can I work on this issue

kisharnath avatar Oct 31 '23 12:10 kisharnath

Hey sorry @kisharnath , I just remove "good first issue", as it turned out to be a bit more involved. You can check out this PR for more details on what is needed https://github.com/wasp-lang/wasp/pull/1538, but if that seems like too much (running haskell codebase, running tests, ...), then I advise to skip this issue.

Martinsos avatar Oct 31 '23 13:10 Martinsos