open-saas
open-saas copied to clipboard
Empty links in the footer on the https://opensaas.sh website
There are 2 empty links in the footer on the https://opensaas.sh website ("Privacy" and "Terms of Service")
<div>
<h3 class="text-sm font-semibold leading-6 text-gray-900 dark:text-white">Company</h3>
<ul role="list" class="mt-6 space-y-4">
<li><a href="https://wasp-lang.dev" class="text-sm leading-6 text-gray-600 hover:text-gray-900 dark:text-white">About</a></li>
<li><a href="#" class="text-sm leading-6 text-gray-600 hover:text-gray-900 dark:text-white">Privacy</a></li>
<li><a href="#" class="text-sm leading-6 text-gray-600 hover:text-gray-900 dark:text-white">Terms of Service</a></li>
</ul>
</div>
Hm true! @vincanger is that because we are leaving them to the user of the template to implement? In theory we could put something of our own specifically for opensaas.sh although I wonder if that is needed or not, I don't have much experience with these and the legal side of it.
I left them blank as I didn't see a need for them. The MIT license is in the github repo so maybe we could link to that @Martinsos and remove privacy as we're using Plausible and don't collect any cookies?
@vincanger sounds good to me! Hm, let's think about it this way actually: we want these to be there for people, but also to have sane defaults. One option is to remove empy links and they can always add them. Yeah, why not, that is the safe optin. Another optino is to have them point to be blank, but then we will want to point out in docs they will probably want to fill those in. I am ok with removing them I tihnk. The only option that could be problematic is if we make them point to some mock stuff, or even Wasp stuff, and then they forget to update them, and they have wrong stuff there wrong privacy and similar, or even wrong license, that wouldn't be great.
this was fixed with v2.0, it seems!