wasm-chisel icon indicating copy to clipboard operation
wasm-chisel copied to clipboard

Verify numeric instructions

Open zixuanzh opened this issue 6 years ago • 8 comments

As per issue #18

parity-wasm checks types for const operators but not for binary as specified in the spec.

We simulated the stack to check for types and hence we added a new validator interface that takes in a mutable self reference. We also use a self defined enum instead of String for error handling and propagation as advised by the documentation.

zixuanzh avatar Dec 06 '18 15:12 zixuanzh

@zixuanzh CI is failing because you need to run cargo fmt. just FYI

jakelang avatar Dec 06 '18 15:12 jakelang

@zixuanzh CI seems to be a version behind on rustfmt. will fix that.

edit: actually that doesn't seem to be the problem. trying to find out why fmt is still freaking out.

edit 2: Are you sure you are using the correct version?

jakelang avatar Dec 06 '18 15:12 jakelang

I am running on 1.32.0-nightly, fmt fails at deployer.rs etc in CI, it passes CI when I only commit verify-instructions related files.

zixuanzh avatar Dec 06 '18 15:12 zixuanzh

@zixuanzh is this ready or WIP? Please add the respective label.

Also please rebase.

jakelang avatar Dec 20 '18 21:12 jakelang

@jakelang it should be ready as it is unless @Steampunkery has something to add, we don't have access to add labels.

zixuanzh avatar Dec 21 '18 05:12 zixuanzh

I think this looks good in general, great work @Steampunkery and @zixuanzh!

axic avatar Dec 21 '18 13:12 axic

@Steampunkery @zixuanzh can we take over this PR or do you think you'll have some resources to work on this in the next while?

axic avatar Jan 26 '19 16:01 axic

@axic please proceed, we are unlikely to work on this in the immediate future. thanks

zixuanzh avatar Jan 31 '19 05:01 zixuanzh