fizzy icon indicating copy to clipboard operation
fizzy copied to clipboard

Invoke refactoring

Open chfast opened this issue 4 years ago • 5 comments

Depends on #602.

chfast avatar Oct 01 '20 13:10 chfast

Codecov Report

Merging #564 (d43e3af) into optimize_call_result_push (90bd063) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@                    Coverage Diff                     @@
##           optimize_call_result_push     #564   +/-   ##
==========================================================
  Coverage                      99.27%   99.28%           
==========================================================
  Files                             86       86           
  Lines                          13219    13218    -1     
==========================================================
  Hits                           13123    13123           
+ Misses                            96       95    -1     
Flag Coverage Δ
rust 98.67% <ø> (+0.09%) :arrow_up:
spectests 89.97% <100.00%> (-0.01%) :arrow_down:
unittests 99.21% <100.00%> (-0.01%) :arrow_down:
unittests-32 99.31% <100.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/fizzy/execute.cpp 99.29% <100.00%> (-0.01%) :arrow_down:
bindings/rust/src/lib.rs 98.95% <0.00%> (+0.09%) :arrow_up:

codecov[bot] avatar Oct 01 '20 13:10 codecov[bot]

Rebased on top of #602. Can be benchmarked too.

axic avatar Nov 06 '20 17:11 axic

@chfast maybe this with #602 would be measurable saving? It removes the passing of func_type.

axic avatar May 29 '22 22:05 axic

@chfast maybe this with #602 would be measurable saving? It removes the passing of func_type.

Yes. This was main goal.

chfast avatar May 30 '22 12:05 chfast

Rebased. If we want to keep the assertion from #602, then need the last commit, which likely negates all the benefits.

axic avatar May 30 '22 12:05 axic