wasmi
wasmi copied to clipboard
Add CI that automatically runs benchmarks and posts them to the PR
After https://github.com/paritytech/wasmi/issues/304 has been implemented it would be nice to have benchmarks run automatically for every PR and PR update similar to how it is already done with test coverage reporting via codecov.io.
I personally do not know what needs to be done with GitHub Actions CI or if that's actually feasible without a ton of work.
I found this GitHub Actions and will try to make it work for wasmi.
My personal summary is that https://github.com/marketplace/actions/criterion-compare-prs is not a fit to close the linked issue since the GitHub Actions unfortunately is heavily outdated and has outdated documentation which is a red flag anyways.
We need to look for another solution or build our own GitHub Actions for comparing Citerion benchmarks.
Closed.
Did not want to close this issue but the linked PR: https://github.com/paritytech/wasmi/pull/324
Maybe running Criterion benchmarks on GitHub Actions CI is too noisy. The well known Cachegrind tool is made exactly for usage scenarios like these. The experimental (unreleased) lai tool from the same author as Criterion might help here.
This is being worked on by @sergejparity here https://github.com/paritytech/wasmi/pull/422.
Implemented in https://github.com/paritytech/wasmi/pull/422. Closed.