wasmer icon indicating copy to clipboard operation
wasmer copied to clipboard

Removed trailing zero in WASI::fd_prestat_dir_name name return (for #3025)

Open ptitSeb opened this issue 3 years ago • 2 comments

Description

Removed trailing zero in WASI::fd_prestat_dir_name returned name (for #3025)

ptitSeb avatar Aug 02 '22 12:08 ptitSeb

Posix defines character strings as null terminated, personally I'd like all path strings that go out into a module to be null terminated. What do you think?

epilys avatar Aug 02 '22 13:08 epilys

I agree, but this is WASI here, not POSIX. check the ticket mentioned for more detail. Not sure the change should be done. But if we don't it, we should close the mentioned ticket as a "will not be done"

ptitSeb avatar Aug 02 '22 14:08 ptitSeb

bors r+

ptitSeb avatar Oct 13 '22 13:10 ptitSeb

Build succeeded:

  • Code lint

bors[bot] avatar Oct 13 '22 13:10 bors[bot]