wasmer icon indicating copy to clipboard operation
wasmer copied to clipboard

Windows release does not contain a import library for the dll

Open madebr opened this issue 3 years ago • 1 comments

Describe the bug

The 2.0.0 Binary Windows release of wasmer does not contain an import library for linking with the dll.

Currently, the archive looks like:

└── wasmer-windows-amd64
    ├── ATTRIBUTIONS
    ├── bin
    │   ├── wapm.exe
    │   ├── wasmer.exe
    │   └── wasmer-headless.exe
    ├── lib
    │   ├── wasmer.dll
    │   └── wasmer.lib
    ├── include
   ...

It is missing: wasmer.dll.lib. Additionally, wasmer.dll should be put in the bin folder.

The tree should thus become:

└── wasmer-windows-amd64
    ├── ATTRIBUTIONS
    ├── bin
    │   ├── wapm.exe
    │   ├── wasmer.dll
    │   ├── wasmer.exe
    │   └── wasmer-headless.exe
    ├── lib
    │   └── wasmer.dll.lib
    │   └── wasmer.lib
    ├── include
   ...

Steps to reproduce

  1. Download the windows binary release.
  2. Write a mini wasmer user
  3. I cannot link to wasmer.dll because no import library is available.

Expected behavior

lib/wasmer.dll.lib is available.

Actual behavior

lib/wasmer.dll.lib is not available.

Additional context

Theoretically, it is possible for users to generate an import library using dumpbin or pexports. But it should be part of the SDK because using the tools above might pick up internal symbols of wasmer.

madebr avatar Nov 12 '21 18:11 madebr

Hey, @Amanieu any updates on this issue?

aadarshadhakalg avatar May 15 '22 11:05 aadarshadhakalg

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 15 '23 15:05 stale[bot]

Recent releases ship .dll.lib import libraries, so this issue got resolved. Thanks!

madebr avatar May 15 '23 15:05 madebr