wasmCloud icon indicating copy to clipboard operation
wasmCloud copied to clipboard

Published 20 hours ago • verified publisher icon wasmCloud

[REQUEST] Lame Duck Mode

Open jordan-rash opened this issue 1 year ago • 9 comments

As an extension to #692, I would like to see the "lame duck" tag implemented.

Similar to NATs lame duck mode, it would cause the host to drain itself and block further deployments (from wash and wadm) to the host. This would allow for easier updates of the host in place.

Ref: https://wasmcloud.slack.com/archives/C04RVMJJH17/p1695735058510099

jordan-rash avatar Sep 26 '23 14:09 jordan-rash

Some questions on this one:

  • once in lame duck mode, should the host refuse to process any new control interface commands, or is this mode "just' part of what's returned by host pings/inventory requests?
  • once the host has drained its contents, will it shut down, or does it remain in lame duck mode?
    • if the host stays running, should there be a way to switch out of lame duck mode, or is this a terminal state?

connorsmith256 avatar Sep 26 '23 18:09 connorsmith256

IMO:

  • once lame duck mode is enabled, no "new" commands should be processed. All existing workloads should be shutdown nicely (up to some TTL and then killed)
  • I think once it is shutdown, it would remain on and continue to not respond to request. Reason for this is,
    1. maybe I was just troubleshooting something and will take it out of lame duck mode once I am done or
    2. Doing some sort of load testing
  • I def believe lame duck mode should be toggleable

jordan-rash avatar Sep 28 '23 17:09 jordan-rash

We've chatted about this before, and I'd also like to see this as a feature. Conceptually I think it as being closer to Kubernetes' drain/cordon behavior or Nomad's node draining/eligibility feature.

protochron avatar Oct 01 '23 16:10 protochron

We've chatted about this before, and I'd also like to see this as a feature. Conceptually I think it as being closer to Kubernetes' drain/cordon behavior or Nomad's node draining/eligibility feature.

But Dan def thinks that the feature should have duck in the name...right, RIGHT?!?!?

jordan-rash avatar Oct 02 '23 18:10 jordan-rash

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!

stale[bot] avatar Jan 27 '24 23:01 stale[bot]

@jordan-rash did you mean to close this?

thomastaylor312 avatar Mar 13 '24 11:03 thomastaylor312

Going to re-open -- pretty sure this shouldn't have been closed

vados-cosmonic avatar Apr 29 '24 18:04 vados-cosmonic

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!

stale[bot] avatar Jun 28 '24 23:06 stale[bot]

One note here is that lame duck mode should probably be entered automatically if it receives a kill signal

thomastaylor312 avatar Aug 02 '24 18:08 thomastaylor312