wadm icon indicating copy to clipboard operation
wadm copied to clipboard

[FEATURE] Undeploying an app should not impact other apps, even temporarily

Open connorsmith256 opened this issue 1 year ago • 4 comments

Currently, if apps Foo and Bar both use the same provider, and I undeploy Foo, it's possible this will stop a provider which is also part of Bar. (I believe this comes down to whichever app was deployed first) While wadm does reconcile and bring back Bar's provider, this can create downtime for Bar.

Wadm should be "smart" enough to know that removing Foo's provider is not acceptable in this case

connorsmith256 avatar Nov 15 '23 00:11 connorsmith256

Thanks for filing this, we've known about it but haven't tracked it. You are correct in that whichever app deploys first "owns" the provider.

For anyone implementing this, the main obstacle is going to be that we can't modify running providers to have different annotations, so we are going to need to figure out how to start to "own" the provider. Figuring out whether or not it should stay around can be done on wadm's side (though that could also be a little gnarly), but the ownership problem might require a bigger conversation

thomastaylor312 avatar Nov 15 '23 00:11 thomastaylor312

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!

stale[bot] avatar Jan 14 '24 01:01 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!

stale[bot] avatar Mar 17 '24 18:03 stale[bot]

With wasmcloud 1.0, this should now be possible by using the same provider, but with a different ID. However, that has the downside of running two copies of the provider. We should probably still solve ownership by allowing dynamic annotation modification

thomastaylor312 avatar Mar 25 '24 17:03 thomastaylor312

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!

stale[bot] avatar May 24 '24 17:05 stale[bot]

This is no longer an issue since wadm was updated to 1.0 since we don't share resources

brooksmtownsend avatar May 24 '24 19:05 brooksmtownsend