three_dart icon indicating copy to clipboard operation
three_dart copied to clipboard

Published 20 hours ago • verified publisher icon wasabia

Add support for TubeGeometry

Open joakimunge opened this issue 2 years ago • 2 comments

Hi,

I was experimenting using this library for a project, but noticed that the TubeGeometry is not implemented.

https://threejs.org/docs/index.html?q=TubeGe#api/en/geometries/TubeGeometry

Would love if this was implemented. Will try to look into it myself, but I am not very familiar with three.js

joakimunge avatar Oct 10 '22 12:10 joakimunge

@joakimunge Still working on this? I have a project with a working LineCurve3 and TubeGeometry implementation. So if you want I can move that over to the project.

mark-nicepants avatar Oct 24 '22 09:10 mark-nicepants

@joakimunge Still working on this? I have a project with a working LineCurve3 and TubeGeometry implementation. So if you want I can move that over to the project.

Hi @mark-apn

I am not working on it actively, but I had a work in progress going that got merged prematurely. So there is some sort of support there but it was not ready to be merged.

If you have a complete implementation that could be good. I have decided to go another way in my project as I can not rely on the loose merging happening here.

Here is the PR in question so you can see my changes.

https://github.com/wasabia/three_dart/pull/90

joakimunge avatar Oct 25 '22 12:10 joakimunge