Marcin Warpechowski

Results 202 comments of Marcin Warpechowski

Rationale for 3. is that we can use it to refresh the content of the composition editor popup window.

This is in progress AFAIK? Or was it "only" the full-stack Starcounter app test that I saw?

Implementation of point 4 not always works as expected: ### Steps to reproduce 1. Run Omni (current master) + Palindrom (I used `document-morphing` branch) 2. Go to the http://backoffice.omni.local:8080/BlendingEditor/compositions page...

Testing point 2, I find it wrong that `morphUrl` calls `getPatchUsingHTTP` without handling the potential rejection. If I use the event `palindrom-before-redirect`, then an ugly error appears in browser console:...

Point 1 was verified OK, I haven't checked 3 yet.

> Hey, what's the status of this? It's blocking: Starcounter/Blending#394 It was partially implemented in PRs #222, #223, #225, #226 and now the remaining stuff is tracked in the PR...

Reopen because point 4 was not fixed yet. There is a problem that I explained in the comment: https://github.com/Palindrom/Palindrom/pull/228#pullrequestreview-216036651 Points 1, 2, 3 are released in Palindrom 6.0.0

This issue is on hold until me and @tomalec agree on the solution for https://github.com/Juicy/imported-template/pull/62. Unassigning @alshakero for the time being.

~~Sorry for late response. This is definitely a bug in Palindrom. I will create a fix by combining the new `X-Location` header with the current window location as the base...

I just discussed with @tomalec that the correct client-side solution is to completely remove treating a new URL as an error. As far as the client is concerned, any URL...