Warp icon indicating copy to clipboard operation
Warp copied to clipboard

Option to disable Fuzzy search, it's making Ctrl+R search useless

Open maxkosty opened this issue 1 year ago • 12 comments

Discord username (optional)

No response

Describe the solution you'd like?

A search that matches everything matches nothing ☯️

Screenshot 2024-02-13 at 3 45 54 PM

Is your feature request related to a problem? Please describe.

No response

Additional context

No response

How important is this feature to you?

1 (Not too important)

Warp Internal (ignore) - linear-label:39cc6478-1249-4ee7-950b-c428edfeecd1

None

maxkosty avatar Feb 13 '24 23:02 maxkosty

Are you requesting a way to disable fuzzy search so that results are more accurate? I assumed you were so modified the request slightly.

To anyone else interested in this feature, please add a 👍 to the original post at the top to signal that you want this feature, and subscribe if you'd like to be notified.

dannyneira avatar Feb 14 '24 00:02 dannyneira

I noticed this and came to Github looking for a solution -- the current Ctrl+R search in Warp is somehow drastically worse than anything that I've used prior, whether fish or zsh's built-in Ctrl+R, fzf, atuin or otherwise.

Honestly this is the number one issue that makes me feel inclined to switch back to another terminal emulator even though I could imagine Warp's teams features being helpful for my team.

Would love to see the Ctrl+R search improved -- I'd hope it's manageable given that it seems to work well in other tools!

tekacs avatar Feb 27 '24 11:02 tekacs

Are you requesting a way to disable fuzzy search so that results are more accurate? @dannyneira I guess best solution would be to have a less aggressively-fuzzy algorithm that returns better matches out of the box by default.

maxkosty avatar Mar 05 '24 20:03 maxkosty

Is there any way I can disable the fuzzy search of warp ? I use fzf already for this. Warps history search is slower and also many of my commands are missing. I find myself calling fzf as an intervention over my history to get m commands now.

jpninanjohn avatar Apr 01 '24 07:04 jpninanjohn

Or maybe change the fuzzy search logic? fzf is more accurate.

See what fzf displays for my history when searching for: cd hi orm (Tilix terminal)

image

Warm terminal:

image

mhagnumdw avatar Apr 03 '24 14:04 mhagnumdw

Or is there a way to let ctrl-r just use fzf like in iTerm? Agreed that the fzf algorithm is just better

ferdy-roz avatar Apr 22 '24 14:04 ferdy-roz

I'd also like an Option to disable the ctrl + r overwrite.

I've been using Atuin before, and have it synced with my other machines (some of which are linux) and i'd love to keep using atuin inside warp.

An option to simply turn off the ctrl-r feature would be great.

JEndler avatar Apr 26 '24 13:04 JEndler

Any update on this ? This is really off putting. My entire history is now unusable due to this. Why try to break some thing that already works really well ? Even if you want to build this in warp. Give us the option to continue with what we have till its completely built.

jpninanjohn avatar Jun 13 '24 05:06 jpninanjohn

Funnily enough I've received two or three "We want to hear your feedback!" emails, and have always just replied with a link to this github issue... And still no traction.

ferdy-roz avatar Jun 13 '24 16:06 ferdy-roz

For now, I am using this as a workaround.

function searchHistory() {
    found=$(history | fzf | awk '{ for(i=1;i<NF;i++) $i=$(i+1); NF--; print }') && eval ${found}
}

Export this function in your shell startup scripts. Its a little slow to execute but the search functionality is from fzf so that solves the main issue. It cannot be bound to ctrl+R though since warp does not provide the option to unbind their search.

jpninanjohn avatar Jun 19 '24 03:06 jpninanjohn

Hey Folks, some improvements to search have been released to the Command Palette. Please try and let us know if the results improved.

Note that you can also specifically filter, by prepending your search term with the following:

workflows: or w: will filter for Workflows. notebook: or n: will filter for Notebooks. prompts: or p: will filter for Prompts env_vars: will filter for Environment Variables drive: will filter for Warp Drive. actions: will filter for Warp-specific actions like settings and features. sessions: will filter for active sessions with Session Navigation. launch_configs: will filter for Launch Configurations.

dannyneira avatar Apr 23 '25 21:04 dannyneira

Are you requesting a way to disable fuzzy search so that results are more accurate?

yes, please! another annoyance, is that a big boost in search is added when searched string starts a word, or even more if it starts the whole command, but sometimes, you just want to look for the last occurrence of an option: let's say, I want to recall the last npm-watch alias, or the last time --watch was used, searching for watch won't recall one of those commands, even if it was the previous one

thanks!

nikophil avatar Jun 15 '25 08:06 nikophil