Warp icon indicating copy to clipboard operation
Warp copied to clipboard

Line height causing visual breakage

Open joetannenbaum opened this issue 2 years ago • 6 comments

Discord username (optional)

No response

Describe the bug

Honestly, I'm not even sure if this is a bug, but I mentioned it on Twitter and was told to file an issue here.

Basically, when using a package such as Laravel Prompts, the output is a bit crunched vertically. When I try to increase the line height, it creates gaps in the output. Somehow iTerm handles this gracefully, not sure how though.

I've tried different fonts, but same result.

To reproduce

Output a box in the terminal and start increasing the line height, you'll see gaps in the lines.

Expected behavior

Gaps shouldn't appear, ideally. The line should be continuous.

Screenshots

CleanShot 2023-08-02 at 08 49 51@2x CleanShot 2023-08-02 at 08 50 34@2x

CleanShot 2023-08-01 at 13 31 37@2x

CleanShot 2023-08-01 at 13 32 21@2x

CleanShot 2023-08-01 at 13 33 22@2x

Operating system

MacOS

Operating system and version

Ventura 13.0.1

Shell Version

zsh 5.8.1 (x86_64-apple-darwin22.0)

Current Warp version

v0.2023.07.25.08.03.stable_00

Regression

No, this bug or issue has existed throughout my experience using Warp

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

No

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

No, this same issue happens in Warp and other terminals.

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

None

joetannenbaum avatar Aug 02 '23 12:08 joetannenbaum

Thanks for the heads up @joetannenbaum. I was able to reproduce it and I'll let the team know. I also noticed the same when I increased line spacing on the default terminal, so increasing line height may not be a bug, but maybe Warp can it may be differently. Any news or fixes for this we'll post on this thread.

CleanShot 2023-08-02 at 15 49 48

dannyneira avatar Aug 02 '23 21:08 dannyneira

Thanks for the prompt response, @dannyneira! Appreciate it.

Someone on Twitter mentioned this, not sure if it's helpful or might point you in the right direction: "The lines breaking apart with line height requires a terminal with box drawing."

joetannenbaum avatar Aug 03 '23 18:08 joetannenbaum

I this this is related to ligature support

elviskahoro avatar Aug 07 '23 18:08 elviskahoro

Another example of this issue.

@dannyneira It would be great if there were any updates about this.

Iterm2

CleanShot 2023-11-07 at 15 57 51@2x

Warp

CleanShot 2023-11-07 at 15 55 23@2x

Tmeister avatar Nov 09 '23 03:11 Tmeister

@Tmeister this isn't being actively worked on ATM; will plan to update you after we figure out our next quarter's OKRs

elviskahoro avatar Nov 09 '23 04:11 elviskahoro

This is the only thing that makes me consider other terminals today :(

victor-falcon avatar Aug 18 '24 15:08 victor-falcon