Warp
Warp copied to clipboard
warpdotdev
Option to remove padding/margin from alt screen apps like vim/nvim
Discord username (optional)
No response
Describe the bug
after updates to 2022.12.06 (v0.2022.12.06.08.03) vim/nvim suddenly have padding/margin that makes it smaller in view. It wasn't like this before.
To Reproduce
- Update to 2022.12.06 (v0.2022.12.06.08.03)
Expected behaviour
- Vim/Nvim span across the parent container
Screenshots
Operating System
MacOS
OS Version
Catalina 10.15.7
Shell Version
zsh 5.7.1 (x86_64-apple-darwin19.0)
Warp Version
v0.2022.12.06.08.03
Additional context
Not sure if this is a bug, haven't tested it in newer OS. I would be okay with just a response. Thank You!
Does this block you from using Warp daily?
No
Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e
None
I also encountered the same issue.
Mac OS Version: Ventura 13.1 (22C65)
Warp Version: v0.2022.12.13.08.04.stable_01
Same here, updated Warp just now.
macOS version: 13.0 (22A380) Warp version: v0.2022.12.13.08.04.stable_01
Thanks for the feedback all, We made some changes to the Alt Screen apps rendering in order to improve reliability and compatibility with Warp, and we'll continue to monitor and adjust as needed.
As a workaround, many alt-screen apps allow you to set a background to None or Transparent, and that should help with the border color difference.
https://user-images.githubusercontent.com/16809145/209020841-1df910f3-0465-4fbc-ad65-4fb0fb880aef.mp4
^ Example of none background in vim ^
this is also an deal-breaker issue for me, keep up the great work warp team, some day you'll be my daily driver
Hey Folks, Changing this to a Feature request for the option to remove/adjust padding in Alt Screen apps which include vim/nvim/less/etc. as mentioned in the comment above, this was intentional to help resolve a number of issues with Alt screens in Warp, so we'd have to add an option in such a way to allow users to reduce/remove the padding, but maintain the reliability/compatibility.
Please add a :+1: to the original post at the top to signal that you want this feature, and then hit the subscribe button if you'd like to be notified.
I've just tried out for the first time warp terminal and it seems really damn cool, the only issue that didn't made me keep using it was really this padding/margin issue. With tmux and vim we can clearly see them and even with the transparent option, it is stealing a lot of space that could be used to display content. It is also an issue sometimes with other terminal emulators actually, even with the one I'm using currently, I couldn't get rid of all of the padding completely but on warp is really big :(
As soon as there will be an option to be able to remove those padding, I'm pretty sure I'll change to warp honestly, it feels really amazing and the helper tools it provides is really awesome.
yes same issue, a lot of people using tmux or zellij with tabs configured per project basis. this padding is super-annoying
no update on this after almost 1 year? I'm not using warp only because this, and others vim/nvim users too.
really there should be an option to disable all this fancy too-much-smart things.
And it's not about padding only for nvim/helix etc need to remove it for everything.
+1, just checked out Warp today and this is the only thing that still keeps me using iTerm.
the only thing that stops me from using warp. I'm quite astonished that a terminal cannot work well with these editors.
This paddings are TOO big for terminal guys like me (and ugly as ~w~hell), I am literally counting every char column. Uninstalling after playing with snippets that looks good to me.
btw also AI must gone completely, it's a negative point to me, kind of violation of my privacy, that would be second big minus to start using warp on daily basis. AI everywhere is pretty annoying thing, I feel the tendency to meet AI on toilet freshener one day.
AI is pretty good thing, but unable to fix paddings for one year is pretty bad.
#3904 just closed as not planned, it seems like we will have to wait for a long time.
Sorry for the long silence on this one. Warp's original behavior was to render alt screen apps with the full width/height of the container, as the issue description here alludes to. And as an implementation detail, this mean the shell's window size differed between the main blocks view and the alt screen view; the terminal window size used for the main blocks view includes padding for the sake of the block UI -- so this meant we had to report terminal window size updates to the shell when switching to/from the alt screen. Unfortunately, some alt screen apps weren't properly responding to terminal resize events, causing more serious issues like #934 and #1710. Hence the current behavior, which is caused by using the same terminal window size for both the blocks view and altscreen view.
The feedback around the annoyingly large padding is heard and this issue is still on our radar (#3904 was closed as not planned because it's a dupe of this issue, not because we aren't ever planning to take a look at this). The fix isn't trivial though; we can't revert back to the old approach given the issues I linked above.
One hacky workaround might be to infer the main bg color of the altscreen app and paint the padding that same color, at least to reduce the visual ugliness. Thoughts on that?
Otherwise, we can re-open an investigation into the original resizing issue, given it's not totally unlikely we land on the today's solution being the best tradeoff.
Reporting terminal size updates to the shell seems like the correct solution. Surprised you noticed many issues with it especially considering how often users already use these apps (tmux, vim) in terminals that adjust size (resizing iTerm2 windows, adjusting font sizes, etc.) fairly often.
@zachbai Thank you for explanation!
For me it's not about color difference (minor thing) but about paddings stealing priceless screen width.
@zachbai but you can inspect experience of others terminal like kitty about this topic ! for first step is just space padding margin not color difference
The reason why this is uniquely a challenge for Warp is because it warrants different terminal sizes between the blocks view and the alt screen.
As soon as you start any alt screen program, the shell emits a control sequence indicating that the emulator (Warp) should switch to the alt screen. And for Warp, specifically, when Warp realizes we're switching to the alt screen, we'd also have to tell the shell that it should be resized (to the bigger alt screen size, eliminating the padding). For some reason this resize message caused some weird rendering issues with a few CLIs (like #1710). But you're right, that emacs responds to terminal resizing generally, so I'm not sure what the root cause was.
This is really annoying for terminal gay while useing vim/nvim~ looking forword resolving,thanks :)
Could you just add a config option to make the padding removable for everything? Either a px value selector or a toggle for on/off. As far as I understood the issue is that the "view" would get resized if you only want no padding inside vim/other apps. Personally I don't care about padding at all and run my other terminal emulators with 0 padding anyway. If removing the padding in blocks via configuration would allow no padding inside vim that would be a good tradeoff imo.
This is my workaround:
#!/bin/bash
FILE=$1
if [[ "$FILE" != /* ]]; then
FILE=$PWD/$1
fi
echo "Opening $FILE"
i3 exec "terminator -e \"nvim $FILE\""
basically it opens a new window for nvim using terminator instead of warp (works only in i3)
