Warp icon indicating copy to clipboard operation
Warp copied to clipboard

Close tab button is on the wrong side on macOS

Open kitgrose opened this issue 2 years ago • 2 comments

Discord username (optional)

No response

Describe the bug

In macOS, window and tab controls are conventionally on the left side (as opposed to Windows, where controls are normally on the right).

Warp shows the close button for each tab on the right of the tab, which breaks the convention on the platform (see Safari, Finder, Terminal, etc. for standard tab controls on the system, all of which have their close buttons on the left).

To Reproduce

  1. Open multiple tabs in Warp
  2. Hover over a tab with the mouse
  3. Observe that the close button is on the right of the tab

Expected behaviour

The close button should be on the left of the tab

Screenshots

Screen Shot 2022-09-19 at 11 39 41 pm

Operating System

MacOS

OS Version

12.5

Shell Version

zsh 5.8.1 (x86_64-apple-darwin21.0)

Warp Version

v0.2022.09.13.08.15.stable_03

Additional context

No response

Does this block you from using Warp daily?

No

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

No response

kitgrose avatar Sep 19 '22 13:09 kitgrose

This is interesting. I see in Terminal, and Apple app, the close button is on the left side of the tab. But in apps that tend to be cross-platform (Chrome, Firefox, Visual Studio Code) the close button is on the right.

Subterrane avatar Sep 19 '22 16:09 Subterrane

Hi @kitgrose, I'm marking this as a feature request because @Subterrane is correct.

Native apps like Safari close tabs on the left, while cross-platform apps ( which is our intention to eventually support Linux/Windows/Web ), close on the right side. We will post any updates to this request here.

dannyneira avatar Sep 19 '22 23:09 dannyneira

I understand this decision, although it's worth pointing out that there are absolutely cross-platform apps that don't behave this way (e.g. VS Code, Adobe apps, etc.).

kitgrose avatar Sep 26 '22 06:09 kitgrose

@kitgrose is correct that there are cross-platform apps that place the close button on the left. May I suggest, @dannyneira, that this be a setting? Here you can see that my VS Code setup sets the close button on the left:

Screenshot 2023-01-24 at 8 29 01 AM Screenshot 2023-01-24 at 8 25 13 AM

partydrone avatar Jan 24 '23 14:01 partydrone

Came here to file this issue, pleasantly surprised to see it has already been filed.

For the record, Jetbrains products are cross-platform and also have a setting for this.

This is one of those attention-to-detail things that I think would go over well with certain old skool mac enthusiasts.

kpmcguire avatar Jan 27 '23 21:01 kpmcguire

Agree, this is a Mac-only app right now and it should follow macOS ui standards.

narcistesa avatar Mar 24 '23 21:03 narcistesa

Is there any progress on this?

ttuygun avatar Jul 14 '23 19:07 ttuygun

No progress or eta at this time. To realistically set expectations, we focus on the requests with the most 👍 's so the more we can get on this request the better chance it'll be prioritized.

As a stopgap measure, you can quickly close the current session with CMD-W whether it's the active window, tab, or pane. Appreciate your patience and understanding!

dannyneira avatar Jul 14 '23 20:07 dannyneira

you can quickly close the current session with CMD-W

This has nothing to do with the issue whatsoever. Kind of insulting actually.

kpmcguire avatar Jul 14 '23 20:07 kpmcguire

Not my intention really, I understand it's more of a UI/UX issue. Just trying to provide an alternative for closing the tabs since the current implementation is not up to modern standards (i.e. configurable/left-side tab close position).

dannyneira avatar Jul 14 '23 20:07 dannyneira

What separates great from merely good is attention to detail. What I find intolerable about Windows is the pervasive "Good enough" attitude.

Z2Flow avatar Mar 08 '24 13:03 Z2Flow