Warp icon indicating copy to clipboard operation
Warp copied to clipboard

It seems History Search has low performance

Open cvincent00 opened this issue 3 years ago • 3 comments

Discord username (optional)

No response

Describe the bug

When I use History Search feature by pressing Ctrl+R, I get big lag when navigating the options.

To Reproduce

Steps to reproduce:

  1. press Ctrl+R
  2. type command
  3. navigate between options or continue typing

Expected behaviour

smoothly navigation and command recommendation

Screenshots

No response

Operating System

No response

OS Version

macOS Monterey 12.3.1

Shell Version

zsh 5.8 (x86_64-apple-darwin21.0)

Warp Version

v0.2022.07.18.09.06.stable_01

Additional context

No response

Does this block you from using Warp daily?

Yes

Warp Internal (ignore): linear-label:b8107fdf-ba31-488d-b103-d271c89cac3e

No response

cvincent00 avatar Jul 22 '22 10:07 cvincent00

FYI, I am using oh-my-shell, and over 10k commands in history file (.zsh_history), is it the root cause of this problem?

cvincent00 avatar Jul 22 '22 10:07 cvincent00

@cvincent00 can you disable oh-my-shell just for Warp? Look at the configuring and debugging section of our docs: https://docs.warp.dev/help/known-issues

Gonna CC @zheng as she's been improving Warp performance

elviskahoro avatar Jul 26 '22 15:07 elviskahoro

I am able to repro this & I will look at making a fix. oh-my-shell shouldn't be related

zheng avatar Jul 26 '22 16:07 zheng

Hey @cvincent00, @zheng recently made some changes here that should have fixed this issue. Could you confirm you are no longer seeing this?

alokedesai avatar Aug 26 '22 18:08 alokedesai

Hi @alokedesai @zheng , I got latest version of warp (v0.2022.08.23.08.06.stable_01). But it seems no improvement.

cvincent00 avatar Aug 29 '22 06:08 cvincent00

@cvincent00 I had the same issue - the problem was that some of the items in my history file were very large, I solved it by removing the large item and restarting Wrap. I have opened a feature request to exclude large items from the commands search : https://github.com/warpdotdev/Warp/issues/1892

CfirTsabari avatar Sep 28 '22 09:09 CfirTsabari

Thanks Zheng.

warpdotdev-devx avatar Oct 11 '22 09:10 warpdotdev-devx

@cvincent00 Are you still seeing the same issue in latest version of Warp?

dannyneira avatar Dec 14 '22 19:12 dannyneira

@dannyneira I followed @CfirTsabari instruction, removed large items in history file, and updated to latest version. It became more smoothly. Thanks @CfirTsabari 🙏

cvincent00 avatar Dec 29 '22 08:12 cvincent00