Warp icon indicating copy to clipboard operation
Warp copied to clipboard

Not persistent windows resizing

Open madatbay opened this issue 2 years ago • 5 comments

Discord username (optional)

No response

Describe the bug

When I resize the window and close the terminal (with a red button or cmd+Q), the size of the window resizes back to the default value that comes with installation.

To Reproduce

Steps to reproduce:

  1. Go to terminal
  2. Resize the window to another width and height
  3. Close the terminal
  4. Open it againç you'll see your resized window is not persistent

Expected behaviour

When I reopen the terminal window, it should be opened with the custom width and height I resized.

Screenshots

No response

Operating System

MacOS

OS Version

12.3.1

Shell Version

bash: 3.2.57(1)-release, zsh: 5.8

Additional context

No response

Warp Internal (ignore): linear-label:24888f54-df93-45d5-9bdd-e38f740cac19

No response

madatbay avatar May 25 '22 07:05 madatbay

@madatbay thanks for reporting. Is session restoration enabled in settings? can you share a video

elviskahoro avatar Jul 09 '22 06:07 elviskahoro

@elviskahoro here you're link Only size remains in the CMD+Q shortcut option, X's are not working

madatbay avatar Jul 11 '22 17:07 madatbay

The video has been archived @madatbay can you just drop the file here in github. It can embed

elviskahoro avatar Jul 20 '22 16:07 elviskahoro

can we get this please?

it's annoying to use warp when it keeps changing my preference (rectangle window) to square window everytime i launch it.

deadcoder0904 avatar Sep 09 '22 05:09 deadcoder0904

Hi all, I'm Danny, Support Engineer with Warp. We are aware of this. I've marked this internally as a feature request. Please +1 this request as it helps us gauge interest. We will post any updates here.

dannyneira avatar Sep 12 '22 20:09 dannyneira

Definitely would like to see this. Additionally, it would be helpful to be able to configure what the new window size is for any new windows created. OS X Terminal has this as well, with a hotkey (cmd-option-0) to resize the current window to be the default window size. The hotkey is useful because the window size changes if you sleep the display and swap monitors.

Screenshot 20221113132742@2x

danaspiegel avatar Nov 13 '22 18:11 danaspiegel

Persistent window sizing with setting dimensions manually would be amazing. If not that then at least just honor whatever we last set the window size to. +1

dezerving avatar Nov 14 '22 07:11 dezerving

+1

zormandi avatar Nov 17 '22 10:11 zormandi

+1

jcastro avatar Nov 18 '22 18:11 jcastro

guys don't unnecessarily do +1. just react 👍 on first comment.

lots of people are subscribed to this issue get useless notification emails.

deadcoder0904 avatar Dec 01 '22 08:12 deadcoder0904

It would be handy to set window size in launch configurations.

esycat avatar Jan 19 '23 14:01 esycat

+1 for the hotkey window height

jackbow avatar Mar 17 '23 15:03 jackbow

+1! Persistent/configurable window size is much needed! It's the only "big" productivity issue I am facing right now with Warp

Haruno19 avatar Mar 17 '23 22:03 Haruno19

+1 persistent/configurable window size - Warp only prioritizes for AI and forget basic things like it.

devajmeireles avatar Mar 23 '23 15:03 devajmeireles

This is a must have. Additionally, I would suggest setting the default size to be a lot smaller. On a MacBook Pro, the window takes up about 2/3 of the screen.

glhrmv avatar Mar 26 '23 19:03 glhrmv

image

Yes, each of us came here would want this feature. But you can simply click the little thumb-up button rather than reply how you want this feature badly because the subscribers of this issue just wanna see some progress, not these complains. Thanks! :)

RoyRao2333 avatar Mar 27 '23 01:03 RoyRao2333

Consolidated several requests into this one, requesting persistent/configurable window size/location on window open/in launch configurations.

dannyneira avatar Mar 28 '23 16:03 dannyneira

I'm currently working on (parts) of this request and would love feedback on whether I'm doing it in a way that satisfies folks needs.

Part 1: Reopen closed windows with the same size and location -- check out this video and let me know if it's right

https://user-images.githubusercontent.com/8727141/235011000-b5c4103c-797a-4e90-b645-7495d7c6bcac.mov

Part 2: Set a default size for all new windows -- is this the correct idea?

Image 2023-04-27 at 5 16 15 PM

zachlloyd avatar Apr 27 '23 23:04 zachlloyd

That looks great! Thanks for working on it!

I'm curious if it fixes my personal use case which is with the dedicated hotkey window (settings -> features -> keys -> global hotkey -> dedicated hotkey window) (which I've got at 100% width, 40% height & pin to top). I want to be able to open the hotkey window, drag the bottom window border to enlarge the window, dismiss the window, re-open it, and have the same height as previous.

Here's a video of how it works for me now (on v0.2023.04.25.08.05.stable_00): https://user-images.githubusercontent.com/15710512/235026787-8d579015-d3b0-406a-88ef-b1ed64f11a49.mov

Here's a video of how it would ideally work (using iterm): https://user-images.githubusercontent.com/15710512/235027110-60bb343a-8005-462d-b585-d88bb209b7fe.mov

jackbow avatar Apr 28 '23 00:04 jackbow

Great call on the hotkey window - I would have missed that. I'll make sure that works correctly.

zachlloyd avatar Apr 28 '23 15:04 zachlloyd

@jackbow how would you expect the "remember the last size" behavior to interact with the explicit settings for height and width?

Image 2023-04-28 at 1 39 51 PM

Some options:

  • We could default those settings to be only for the first time you open the window and remember the last size by default
  • We could add another explicit setting around "remember the quake windows last size" that overrides the size from settings

@robbieejones any thoughts?

zachlloyd avatar Apr 28 '23 19:04 zachlloyd

Either of the options sound good to me 👍

jackbow avatar Apr 28 '23 20:04 jackbow

@zachlloyd I personally prefer option 1 as it's simpler.

robbieejones avatar Apr 28 '23 22:04 robbieejones

@jackbow Actually, we debugged this internally, and it's already supposed to be working the way you suggest, but on some kinds of monitors there's a bug (which I'm going to try and fix).

If you change your hotkey setting from Active Screen to Main Screen does that workaround fix it for you?

Image 2023-04-28 at 5 43 38 PM

zachlloyd avatar Apr 28 '23 23:04 zachlloyd

@zachlloyd that looks great, thanks! Two questions:

  1. Does that part 1 behavior--recall of last size and location after close--work the same way after quit, as well?
  2. What's the behavior across multiple MacOS Spaces?

Re question 2, I think "expected" to me would mean the last size/location from any space to determine the next new window size/location on another Space. For example, if I were to relocate and resize a window in one space, switch to another space, and open a new window there, it would have the same size and location of the last one I interacted with on the previous desktop. But whatever is the norm is fine, just wouldn't want the Spaces handling to get overlooked since I'm a heavy user of them.

Totally fine if any of that is not in scope, too, just asking!

lou-daiglecostello avatar Apr 29 '23 21:04 lou-daiglecostello

Hi, In my case, as explained in the issue I opened, mentioned above, no matter which screen I choose, it always opens on the same screen, as if it could read which screens I have, but not managing to open anywhere except the screen it's on (or my main screen when laptop is closed, or laptop screen when it's open).

Hope the extra info helps.

Yonben avatar May 01 '23 21:05 Yonben

FYI this is partially fixed in our latest release: v0.2023.05.09.08.03.stable_01

We now remember and reopen windows at the position and size of the last closed window.

I'm working on a setting for opening windows at a default size now

zachlloyd avatar May 12 '23 15:05 zachlloyd

I do not know about all this hot key stuff; however; dana's November 13 post, above; the macOS window settings were shown and that is what I thought was being asked, and what I am looking for. That is when I drag to resize a window to my liking, I would like to see a way to save that size so that it returns if I close the window or if I quit the Warp application. To date, that is not happening, in that I have to resize every time that I open the application. I had hoped that simply clicking on that check mark while in Settings would do the job, but no joy. Perhaps I am, or evidently I am missing something, but I had thought that going to Settings would be the natural place to adjust and set the window size.

OldSubSailor avatar May 25 '23 15:05 OldSubSailor

It would be great if there was also support for specific window sizes in launch configurations. Right now, when I open warp normally, I always get a full-size/maximized window (which is what I want), but if I open a launch configuration its using some random window size (about 50% of screen?)

apolzon avatar Aug 14 '23 21:08 apolzon

Hi Folks, Warps Appearance Settings allow you to set a custom size for new Windows. See more in our docs https://docs.warp.dev/appearance/opacity-blurring-dimming#window-size

CleanShot 2023-08-23 at 10 14 03

dannyneira avatar Aug 23 '23 16:08 dannyneira