warp-core

I'm not convinced this will close #4240. That PR is also requesting some visual indicator that would tell the player which ship is canning them (instead of just giving the...

Is the OP up to date?

> There seem to be some concerns regarding the ion resistance and ion protection, so I'd like Warp to take a look over this and see if it is appropriate...

Please fill out the template. As it is, this issue is likely to be closed; you haven't even given reasons for your proposed changes.

> Is this max number of the fleet in the system at one time, or max number of times (presumably per day?) that this fleet will enter the system? ~I...

@Amazinite @Zitchas Should the fleet cap only consider the flagship of a fleet (if that ship leaves/is destroyed, its instance of the fleet no longer contributes towards the cap, even...

If I read it right, the check was only happening when a ship is being removed, not continuously.

> Why are you using fleetIds instead of just having pointers to the fleets? I don't think Engine has access to the instantiated fleet object? I think doing it that...

I don't think this is actually updating the counter in System properly, either. I'm going to open a PR to the branch for this that should fix it.

An additional issue that occurs to me: fleetIds seem to only be unique within a system, so if a ship moves to a different system, it may prevent fleets spawning...