r2dec-js icon indicating copy to clipboard operation
r2dec-js copied to clipboard

Use QuickJS-NG

Open wargio opened this issue 1 year ago • 9 comments

Adds support to quickjs ng

wargio avatar Oct 15 '24 17:10 wargio

@trufae

wargio avatar Oct 15 '24 17:10 wargio

Nice!

satk0 avatar Oct 16 '24 10:10 satk0

@trufae if it work for you on iaito, i can merge.

wargio avatar Oct 16 '24 12:10 wargio

Give me few mins to test and i’ll tell you

trufae avatar Oct 16 '24 14:10 trufae

$ ninja -C b ninja: Entering directory `b' [1/6] Generating js/bytecode.h with a custom command FAILED: js/bytecode.h /home/pancake/prg/r2dec-js/b/subprojects/libquickjs/qjsc -m -N main_bytecode -o js/bytecode.h ../js/r2dec-plugin.js Executable output is not supported for this target ninja: build stopped: subcommand failed. pancake@pnuc:~/prg/r2dec-js$

trufae avatar Oct 16 '24 15:10 trufae

doesnt compile for me

trufae avatar Oct 16 '24 15:10 trufae

is this a clean build?

wargio avatar Oct 16 '24 16:10 wargio

Yep. Even in a clean clone

trufae avatar Oct 16 '24 17:10 trufae

That is weird, because the test works: https://github.com/wargio/r2dec-js/actions/runs/11359286375/job/31595154681?pr=332

wargio avatar Oct 17 '24 07:10 wargio

@trufae can you check if it works correctly on macos?

wargio avatar Feb 22 '25 08:02 wargio

Fixes also https://github.com/wargio/r2dec-js/pull/339

wargio avatar Feb 22 '25 09:02 wargio

i can confirm this branch works in r2 and iaito on macos Screenshot 2025-02-24 at 4 54 34 PM

trufae avatar Feb 24 '25 15:02 trufae