warewulf icon indicating copy to clipboard operation
warewulf copied to clipboard

container related code refactor

Open JasonYangShadow opened this issue 1 year ago • 1 comments

Description of the Pull Request (PR):

Unify and refactor container-related code shared between API and wwctl

This fixes or addresses the following GitHub issues:

  • Fixes sub-issue of #918

Before submitting a PR, make sure you have done the following:

JasonYangShadow avatar Apr 24 '24 08:04 JasonYangShadow

@anderbubble this is the first trial of unifying and extracting the common code used between wwctl and API for container-related functions. Feel free to leave comments.

JasonYangShadow avatar Apr 24 '24 08:04 JasonYangShadow

@JasonYangShadow thank you so much for working on this. I'm sorry for the ordering of things, here; but could you rebase this onto current main? It's got a lot of conflicts after the NodeInfo refactor.

I'd like to start prioritizing this and related work for v4.6.0; so if you can get it rebased, I'll definitely be reviewing / merging it asap.

Thanks! sure, will do that today.

JasonYangShadow avatar Oct 31 '24 00:10 JasonYangShadow