Eric

Results 20 comments of Eric

Oh ok, so does that mean it's fine to import from unpkg in this case?

oh, i see edit: it looks like that setInterval is only run when on web discord (I only tested on desktop so ig that's why I didn't notice) i'm a...

ok i just realized that setInterval's delay has to be a 32 bit integer so MAX_SAFE_INTEGER was making it overflow to 0 :skull: technically this made it so the setinterval...

ok it won't prevent you from being AFK on web installs now i'm gonna unmark it as draft now

okk made the changes 👍

> If it can be lazy-loaded remotely and it's genuinely that large then set it up as a dynamically loaded dependency similar to rnnoise: https://github.com/Vendicated/Vencord/blob/main/src/utils/dependencies.ts it was already lazy-loaded because...

now that f74da73 has been added, i'm pretty sure this can be fixed by using the same code that the new regex find uses for the match field as well...

> > now that [f74da73](https://github.com/Vendicated/Vencord/commit/f74da73086b2b361490e028c999c80b3ac2ba76a) has been added, i'm pretty sure this can be fixed by using the same code that the new regex find uses for the match field...

> I mean yeah, but the problem of CheckedTextInput still needs to be fixed I guess we could just not use CheckedTextInput since the Find field just uses TextInput and...

it was crashing if you typed out an invalid regex (firing onMatchChange) so i added regex validation during the canoncalizeMatch() part this way they can still type if it's invalid...