Ward Peeters

Results 176 comments of Ward Peeters

I was more thinking of ```js imageStyle: { objectFit: '', objectPosition: '', } ``` so we just enable these for now and we can upgrade later on and hopefully leverage...

how do we feel about `--disable-storage-reset=` ``` --disable-storage-reset="localstorage,indexdb,websql,cookies,cache,appcache" ```

@patrickhulce we could also do the other way around `--enable-storage-reset="localstorage,indexdb,websql,cookies,cache,appcache"` with those as a default but might be more confusing I don't know 🤔

so we should probably go for `--disable-storage-reset localstorage indexdb websql cookies cache appcache"` using [yargs array](http://yargs.js.org/docs/#api-arraykey)

5% seems so small for React but numbers don't lie I guess. HTTParchive is using wappalzyer which looks like they detect correctly. I probably live in a React bubble so...

@ebidel do we want to move to typescript?

I agree with @ebidel but might be good to put this on the next lighthouse meeting

Moving to types repo gives us extra maintenance overhead so I think we don't want to go that route but exposing it from our package seems a good idea

@adamdbradley what's would be the correct approach here to help implement? 1) Create mutation observer that listens to newly created script tags with type text/partytown and route them through partytown....

Unsure if this is useful but this is another trace I got ``` 13:00:01 PM: ERROR Invalid argument: The dbi 10 was out of range for the number of dbis...