Ian Ward
Ian Ward
Needs some new or modified tests to cover the new parameter.
With some test coverage this looks great. I'll wait until those are done and discuss this change at the next dev call before merging.
Hi @JVickery-TBS I let this slip, do you mind resolving the merge conflicts on this? @EricSoroos how do you feel about these changes in their current state?
Yes we'll want a hard limit on the records returned from delete because it will consume an arbitrary amount of memory, or time out and fail the operation. We should...
@EricSoroos I've added a fix to dsaudit that should address the incompatibility. If that looks good to you please go ahead and merge these changes.
to avoid merge conflicts we regenerate the pot file as part of the release process, not on separate PRs
> @wardi as discussed here is the upstream PR. there is already the `ckan db duplicate_emails` command so no work needed there? It should be updated to ignore case too...
Thanks, I was checking against an older version where it didn't
this reminds me that we're missing a test that creates a db with the migrations then checks that `ckan generate migration --autogenerate` doesn't generate anything
earlier discussion https://github.com/ckan/ckan/issues/7723 with a fix for 2.11 and master https://github.com/ckan/ckan/pull/7934 (although no fix for the unique index in the db)