Ian Ward

Results 431 comments of Ian Ward

It's a little concerning that `ckan/tests/lib/search/test_query.py::TestPackageQuery::test_name_multiple_results` is a flaky test :thinking:

Another benefit is the stack traces and profile outputs of rendering templates are much cleaner. Here's the existing code with a {% snippet %} that inserts 8 stack frames and...

@smotornyuk @amercader I've removed caching for snippets without parameters. It seems jinja2 caching ignores everything, including the language setting, making it useless on many sites and not worth the breaking...

Just found a problem with variables in the parent templates leaking into the snippets. Working on a different approach using `{% import %}` and `{% macro %}` instead.

The old code has 7 stack frames between snippet tag and the actual snippet html: ```python-traceback File "/srv/app/src_extensions/ckan/ckan/templates/development/primer.html", line 21, in block 'secondary_content' {% snippet 'development/snippets/nav.html', heading='Navigation' %} File "/srv/app/src_extensions/ckan/ckan/lib/jinja_extensions.py",...

@smotornyuk my pyright errors don't look like the ones from CI. It *is* using the pyproject.toml settings so there must be something else I'm missing, here are some of the...

Discussion from the dev call: - we should update `activity_create` API to accept no user for actions performed with ignore_auth=True - before activity was a plugin, actions would directly insert...

I'd like to see this as something like `h.unix_locale_to_bcp47(h.lang())` with this replace as an initial implementation and a fixme to do a proper conversion in the future. At least this...

@mutantsan I've been able to use ckanapi with a site protected by basic auth by using `-r https://username:[email protected]` on the CLI. You should be able to do the same with...