warden icon indicating copy to clipboard operation
warden copied to clipboard

Published 20 hours ago • verified publisher icon wardenenv

Scoped environment config loading

Open tdgroot opened this issue 2 years ago • 12 comments

This pull request allows developers to provide user-level and project-level customizations to Warden development environments. For example, if a developer wants to create a phpMyAdmin service for all environments, he could create a ~/.warden/environments/includes/db.base.yml or perhaps in <project_dir>/.warden/environments/includes/db.base.yml:

version: "3.5"
services:
  phpmyadmin:
    hostname: ${WARDEN_ENV_NAME}-phpmyadmin
    image: phpmyadmin/phpmyadmin:latest
    environment:
      - PMA_HOST=db
    depends_on:
      db:
        condition: service_started
    labels:
      - traefik.enable=true
      - traefik.http.routers.${WARDEN_ENV_NAME}-phpmyadmin.priority=3
      - traefik.http.routers.${WARDEN_ENV_NAME}-phpmyadmin.tls=true
      - traefik.http.routers.${WARDEN_ENV_NAME}-phpmyadmin.rule=Host(`phpmyadmin.${TRAEFIK_DOMAIN}`)
      - traefik.http.services.${WARDEN_ENV_NAME}-phpmyadmin.loadbalancer.server.port=80

It also allows developers to develop (and share) custom environment types, without having to edit Warden core files.

tdgroot avatar Nov 15 '21 14:11 tdgroot

Would this resolve #285?

navarr avatar Nov 15 '21 14:11 navarr

@navarr yes, I do think so. One could change the default image for a given service and warden env up!

tdgroot avatar Nov 15 '21 14:11 tdgroot

@davidalger, could you review this PR?

ihor-sviziev avatar Nov 15 '21 21:11 ihor-sviziev

When to expect this feature to be merged to stable release? It'll be highly eligible in my project.

sszymkowiczpg avatar Nov 26 '21 10:11 sszymkowiczpg

Found out that the scoped loading was missing for the Mutagen configuration loading, so I added that!

tdgroot avatar Nov 30 '21 15:11 tdgroot

@davidalger please review this PR

ihor-sviziev avatar Jan 28 '22 18:01 ihor-sviziev

@ Maintainers Whats the status of the PR? +1

poespas avatar Feb 14 '22 08:02 poespas

@davidalger Have you had a chance to review this yet? :)

poespas avatar Mar 22 '22 08:03 poespas

@davidalger what can I do to help to merge this PR? 🙏

sszymkowicz avatar May 20 '22 03:05 sszymkowicz

Anyone still interested in this PR?

@davidalger UP

sszymkowicz avatar Aug 10 '22 06:08 sszymkowicz

I believe that we can create community driven fork due to @davidalger lack of free time

Den4ik avatar Aug 10 '22 11:08 Den4ik

@Den4ik, actually, it's already there https://github.com/swiftotter/den/discussions/5

ihor-sviziev avatar Aug 10 '22 12:08 ihor-sviziev

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Nov 09 '22 05:11 stale[bot]

Manually merged from Den in 5a24ca7d50790e35d7856ef5aaa9002040ff5e46

navarr avatar Jan 17 '23 04:01 navarr