PhpDeprecationDetector icon indicating copy to clipboard operation
PhpDeprecationDetector copied to clipboard

Any plan to allow symfony/console ^6.0?

Open steevanb opened this issue 3 years ago • 1 comments

Hi,

Everything is in the title ;)

steevanb avatar Dec 30 '21 15:12 steevanb

Need to test it, may be support is just one-line change without defects. Will try to update in near future

wapmorgan avatar Jun 16 '22 09:06 wapmorgan

@wapmorgan any updates on the topic?

Axent96 avatar Jan 18 '23 15:01 Axent96

@wapmorgan symfony/console v5 is today a bit old. The issue block to use your nice detector :)

Axent96 avatar Mar 02 '23 16:03 Axent96

@wapmorgan here is PR #72 for the issue. I found no problem for symfony/console ^6.0

Axent96 avatar Mar 03 '23 07:03 Axent96

Issue is fixed by https://github.com/wapmorgan/PhpDeprecationDetector/pull/72, merged and released in 2.0.30

Issue can be closed

kkmuffme avatar Mar 16 '23 08:03 kkmuffme

Not really ;)

I've tried it with Symfony 6.2, and i have this error: Fatal error: Uncaught TypeError: Symfony\Component\Console\Output\Output::writeln(): Argument #1 ($messages) must be of type Traversable|array|string, null given, called in /composer/vendor/wapmorgan/php-deprecation-detector/src/ScanCommand.php on line 306 and defined in /composer/vendor/symfony/console/Output/Output.php:97

From this file: https://github.com/wapmorgan/PhpDeprecationDetector/blob/master/src/ScanCommand.php#L306

steevanb avatar Mar 16 '23 13:03 steevanb

@steevanb Do you can please check PR #74 for symfony v 6.2 @kkmuffme FYI

Axent96 avatar Mar 16 '23 17:03 Axent96

https://github.com/wapmorgan/PhpDeprecationDetector/pull/75 was missing

szaimen avatar Mar 19 '23 09:03 szaimen

@szaimen thanks, seems like it fix the bug. could you please create 2.0.32 with it?

steevanb avatar Mar 20 '23 14:03 steevanb

Sorry, I don't have the permissions to create a new release...

szaimen avatar Mar 20 '23 14:03 szaimen

@wapmorgan a little ping to create the version? thanks :)

steevanb avatar Mar 20 '23 14:03 steevanb

@wapmorgan || @kkmuffme ping for new release tag with last merge into master branch :)

Axent96 avatar Mar 22 '23 08:03 Axent96

Created new version 2.0.32.

wapmorgan avatar Mar 24 '23 20:03 wapmorgan