Wanpeng Li

Results 34 comments of Wanpeng Li

should not make such a big PR should not contains place holders

the most important problem is still there: https://github.com/Azure/azure-webpubsub/pull/446#discussion_r954770610

since this version is hurry to onboard, please fix the following main issues, other issues can be fix later: 1. cookie banner looks like is not ready, need double check...

due to conflict issue, update in #453 #454 #455 #456 so close this PR

> Live trace tool doesn't auto reconnect previously, the reconnect will be stop after some time, now reconnect will try per 5 second forever when it's disconnected fixing in https://github.com/Azure/live-trace-tool/pull/18/files...

> Type invalid url template, Save fixed in Pull Request [5287896](https://msazure.visualstudio.com/One/_git/OSSServices-SignalR-PortalExtension/pullrequest/5287896): check validation before save.

> What is valid hub name fixed in Pull Request [5287909](https://msazure.visualstudio.com/One/_git/OSSServices-SignalR-PortalExtension/pullrequest/5287909): describe a valid hubname

>Delete a hub needs double confirm fixed in Pull Request [5288157](https://msazure.visualstudio.com/One/_git/OSSServices-SignalR-PortalExtension/pullrequest/5288157): add confirm dialog when click delete button

> Cannot edit hub setting after creating a new hub > Unsaved changes alert if there is no unsaved change Same root cause: modify settings when save operation doesn't finished...