react-medium-editor icon indicating copy to clipboard operation
react-medium-editor copied to clipboard

Remove overhead dependencies

Open vansosnin opened this issue 9 years ago • 2 comments

Hello! You use babel 6, so it seems like no need to use package object-assign, better use ES6. Also in my opinion there is no need to pull dependency blacklist for 10 lines of code so I just replaced it with helper function.

vansosnin avatar Apr 11 '16 06:04 vansosnin

Well actually you could use destructuring to get rid of extra props:

render() {
  var { contentEditable, tag, dangerouslySetInnerHTML, ...props } = this.props;

  elementProps = {
      ...props,
      contentEditable: true,
      dangerouslySetInnerHTML: {__html: this.state.text}
  };

  return React.createElement(tag, elementProps);
},

shark0der avatar Jul 02 '16 00:07 shark0der

Thanks. Should I fix it so my pull request could be merged?

vansosnin avatar Jul 03 '16 14:07 vansosnin