wangzihuacool

function "size" uses the same name with parameter "size" ,which may lead to errors

> > I suspect the sync.Once solution is incorrect and that this issue is true. > > Thanks for your reply, that there is way to avoid this problem? >...

Restore db connection charset to utf8mb4, no need to change charset to latin1.

> @wangzihuacool thanks for this PR! Currently it is not passing CI checks, could you remedy this when you have time? 🙇 Thank you for your reply. I have made...

alter-charset migration tests failed. Since we changed the column value to bytes, there is no character set conversion when applying DML events. To support changing the character set of the...

I've made some changes. If the column value got from binlog event is a string type and no charset conversion, it will be converted to bytes;otherwise we just fall back...

> Meet the same problem :( Nice fix! > > A question for the fix: If the `insert` is not the max/min ID, or it's a `update` ,data may lost...

> > > > rowcopy是分批次的。 如果update的数据已经rowcopy过了，事务依然是会丢失的。 no data will be lost when adding a read lock to the query in ReadMigrationRangeValues

After analyzing and testing, I found that the problem is encoding.NewDecoder() in types.go ``` if encoding, ok := charsetEncodingMap[this.Charset]; ok { arg, _ = encoding.NewDecoder().String(s) } ``` So, I added...

> I'm sorry, my previous description about latin1 was a bit misleading. Actually, the main change here is to convert the column value parsed by the binlog event into binary...