udp2raw icon indicating copy to clipboard operation
udp2raw copied to clipboard

Redundant Condition in Cipher Mode Check

Open XiaoLey opened this issue 1 year ago • 1 comments

Description

It has been observed that there are two lines of code where the condition check for the cipher mode appears to be redundant. Specifically, both instances check for the same condition twice within a single statement.

image

Code Location

The redundant condition appears in two different locations:

Link to code location 1

Link to code location 2

Possible Typo?

It might be a typo that the second condition was intended to check another cipher mode, potentially cipher_aes128cfb. It's worth verifying whether this was the intended logic.

Suggested Action

It would be advisable to review these conditions and correct them if one of them should indeed be cipher_aes128cfb, or if another cipher mode was intended to be checked.

XiaoLey avatar May 12 '24 04:05 XiaoLey

Hi this is a bug, if --fix-gro is enabled for cipher_aes128cfb the 16bit gro header is by mistake left unencrpyted.

I will make a fix, hopefully next weekend.

Thanks for reporting.

wangyu- avatar May 13 '24 07:05 wangyu-