Weijun Wang

It will be nice if the test itself can confirm the correctness since this is not a manual test (and we definitely want to avoid manual test as much as...

Yes, or you can write an individual test.

`SmartLoginModule.java` is a class used by a test, itself is not one since there's no `main()` method. Your new test needs to be a regression test, which means before the...

There is a .jtr file inside the JTwork directory containing the detail output.

There are quite some JAAS tests inside `test/jdk/javax/security/auth/login` where you can copy. The one you found has a very old copyright header and invalid format (like trailing spaces...). Also, I...

I meant you can add **both** `UnixLoginModule` and `NTLoginModule` as OPTIONAL. On Windows, `UnixLoginModule` would fail, and on *nix, `NTLoginModule` will fail. Then you can observe the newly added debug...

BTW, have you reverted your change on `LoginContext.java`. I remembered we agreed that this bug is all about debug info instead of updating the exception thrown.

My own suggestion is that we dump the call stack info of the exception if an OPTIONAL login module fails to login and when debug is on. This is not...

Great, the test looks fine. Now, let's come back to the bug fix itself about failure reason of an optional LoginModule. In the "cross-platform" test case, only "[LoginContext]: login OPTIONAL...

Why the new change? The bug is about an optional LoginModule failure not logged, and it only happens when there are multiple login modules and the overall login succeeds.