expression-search icon indicating copy to clipboard operation
expression-search copied to clipboard

Working patch for TB 68.10.0

Open avegaweiss opened this issue 4 years ago • 19 comments

Folks,

I mixed all the different changes for previous fixes, and just upgraded the maxVersion property to match the latest TB update. I cross my fingers.....and it works.

So, best of worlds:

  • no need to restart
  • no doble input
  • working on TB 68.10.0

gmailui-1.4.2_fixed.xpi.zip

avegaweiss avatar Jul 03 '20 21:07 avegaweiss

... just tried this with 68.10.0 and it does not work, unfortunately...

zozimus1 avatar Jul 06 '20 03:07 zozimus1

Thanks! Works for me on 68.10.0 Windows

daniel-lo avatar Jul 06 '20 03:07 daniel-lo

Thanks! Works for me on 68.10.0 (64-bits), Mac OS!

mdvz0r avatar Jul 06 '20 08:07 mdvz0r

Many Thanks! Works for me on 68.10.0 (64-bits), Windows 7

sunfish avatar Jul 06 '20 13:07 sunfish

what version TB and what system

On 7/5/2020 11:32 PM, zozimus1 wrote:

... just tried this with 68.10.0 and it does not work, unfortunately...

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/wangvisual/expression-search/issues/94#issuecomment-653996976, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTLXVHHQCZX57EI2DFTGJDR2FAWLANCNFSM4OQC4JEA.

-- Rich Roth CEO TnR Global

Bio and personal blog: http://rizbang.com Building the really big sites: http://www.tnrglobal.com Small/Soho business in the PV: http://www.hidden-tech.net Places to meet for business: http://www.meetmewhere.com And for relaxation: http://www.welovemuseums.com http://www.artonmytv.com/ Helping move the world: http://www.earththrives.com

rzroth avatar Jul 06 '20 13:07 rzroth

It's also not working for me on 68.10.0 on a 10.15.5 Mac.

The add-ons extension manager is not complaining about the version anymore, but the expression search searchbar is not showing up.

jbeaird avatar Jul 06 '20 13:07 jbeaird

Thanks a lot, avegaweiss!

Your version works for me (Tb 68.10.0 | Win10 64-bit) - after a restart, though!

Frank

fp66 avatar Jul 06 '20 16:07 fp66

No go for me T-bird 68.1 32-bit, running on a 64-bit system—even after a restart. T-Bird launches but I can't see any emails or accounts. Need to launch in safe mode to remove the add-on and recover to normal.

(Let's be clear that the 64-bit version of T-Bird is not officially supported.) I have attached the exception errors.

Expression search errors

karlbu avatar Jul 06 '20 21:07 karlbu

I'm using TB 68.10.0 (64 bit) on Mac OS 10.15.5.

It installs ok, but does nothing. It no longer demands TB be restarted for it to work, but none of the functions or popups appear.

what version TB and what system On 7/5/2020 11:32 PM, zozimus1 wrote: ... just tried this with 68.10.0 and it does not work, unfortunately... — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#94 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTLXVHHQCZX57EI2DFTGJDR2FAWLANCNFSM4OQC4JEA. -- Rich Roth CEO TnR Global Bio and personal blog: http://rizbang.com Building the really big sites: http://www.tnrglobal.com Small/Soho business in the PV: http://www.hidden-tech.net Places to meet for business: http://www.meetmewhere.com And for relaxation: http://www.welovemuseums.com http://www.artonmytv.com/ Helping move the world: http://www.earththrives.com

zozimus1 avatar Jul 06 '20 23:07 zozimus1

I'm using TB 68.10.0 (64 bit) on Mac OS 10.14.6

Same result as zozimus1 It installs ok, but does nothing. It no longer demands TB be restarted for it to work, but none of the functions or popups appear. Tried restart TB, restart Mac, uninstall/reinstall addon - still not working.

geoedgithub avatar Jul 08 '20 04:07 geoedgithub

About Mac OS versions..... I Don't use Mac, but perhaps you can explore a little. I include a simple fix for the double input, that is in the following file within the zip, at the bottom of the file: skin/overlay.css

I commented the original style: /* MODIF x DOBLE INPUT #expression-search-textbox { flex: 5 1; } */

And add this one: #expression-search-textbox > .textbox-input { width: 420px }

Perhaps the css implenentation on Mac is a little different; try arround this going back to original version.

avegaweiss avatar Jul 08 '20 12:07 avegaweiss

Worked for me (W10 64, TB 68.10.0)! Awesome job @avegaweiss - many thanks for fixing thunderbird (again)!

dimitrior avatar Jul 12 '20 15:07 dimitrior

It works for me in Thunderbird 68.10.0 Win x64, but I have to manually enable the Quick Filter Toolbar in the "View" menu setting. It doesn't automatically show up anymore.

sp00n avatar Jul 17 '20 13:07 sp00n

Works here for me: TB 68.10.0 (64-Bit), Debian GNU/Linux Buster. I had to restart TB though. Great to have it back again, many thanks!

sancholito avatar Jul 21 '20 15:07 sancholito

I don't know what I did, but it's now working for me on my Mac. I suspect one of the times I removed and re-added it, I followed @sp00n 's advice and manually enabled it in the View menu. Happy camper! Thanks!

jbeaird avatar Jul 21 '20 16:07 jbeaird

When I install it and I do ctrl-click on a subject etc it does pop up in the search box, and the info window pops up (see below). But it doesn't search for anything. If I click in the box and press enter, it also does nothing.

I tried your edit of the overlay.css file, but it didn't appear to change anything?

image

About Mac OS versions..... I Don't use Mac, but perhaps you can explore a little. I include a simple fix for the double input, that is in the following file within the zip, at the bottom of the file: skin/overlay.css

I commented the original style: /* MODIF x DOBLE INPUT #expression-search-textbox { flex: 5 1; } */

And add this one: #expression-search-textbox > .textbox-input { width: 420px }

Perhaps the css implenentation on Mac is a little different; try arround this going back to original version.

zozimus1 avatar Jul 22 '20 06:07 zozimus1

i.e. that the quick filter tool doesn't work at all any more, despite it being inputted with real text.

When I install it and I do ctrl-click on a subject etc it does pop up in the search box, and the info window pops up (see below). But it doesn't search for anything. If I click in the box and press enter, it also does nothing.

I tried your edit of the overlay.css file, but it didn't appear to change anything?

image

About Mac OS versions..... I Don't use Mac, but perhaps you can explore a little. I include a simple fix for the double input, that is in the following file within the zip, at the bottom of the file: skin/overlay.css I commented the original style: /* MODIF x DOBLE INPUT #expression-search-textbox { flex: 5 1; } */ And add this one: #expression-search-textbox > .textbox-input { width: 420px } Perhaps the css implenentation on Mac is a little different; try arround this going back to original version.

zozimus1 avatar Jul 22 '20 06:07 zozimus1

gmailui-1.4.2_fixed has the same behaviour as reported above - it does not search any more... I am on Ubuntu Linux with TB 68.10.0 (64-bit)

EDIT: turning quick filter on and off, or changing the options on the icons - no search results available at all.

A fix would be much appreciated - If I can support with some testing let me know. Cheers

toxl avatar Jul 25 '20 08:07 toxl

The best solution will be a native TB support, please add your vote here https://bugzilla.mozilla.org/show_bug.cgi?id=538821

malix0 avatar Aug 08 '20 23:08 malix0