expression-search
expression-search copied to clipboard
wangvisual
Patch for TB 68
I made a hacked version (notes below) you can find at: http://www.tnrglobal.com/2020/05/thunderbird-addons/ Hack issues: 1) It does require TB restart although it doesn't report that. 2) I've mainly used search and Ctl-Shift FIELD for searching, SO please try your favorite options and let me know if it works. 3) I don't have access to add better update info 4) FYI, This is a legacy mode extension
I call it hacked because I not a extension pro, even if I am a Kernel level professional programmer. good luck. It is not in any way compromised as many use hacked to mean. If I get github access I will make a branch for this.
Hello rzroth. Thank you for continuing to develop expression search for current versions of T-Bird. Greatly appreciated.
I installed 1.4.2-tb.xpi into version 68.9. While T-Bird launched, I could not access any emails. Nor could I access the Add-ons module to uninstall it. I uploaded the console error report as a word file to this post. (Did not know how to export the file.)
While this sounds promising, I would strongly caution against installing something from a website that doesn't even have HTTPS set up, where the dev claims they don't have github access (from a github account -- what access is lacking? Anyone can fork their repo and develop there)
While this sounds promising, I would strongly caution against installing something from a website that doesn't even have HTTPS set up, where the dev claims they don't have github access (from a github account -- what access is lacking? Anyone can fork their repo and develop there)
@markwmuller I second that. That being said, though, the .xpi is just a zip which you can unpack and verify the Javascript code for any malicious/suspicious actions (I haven't done that myself).
@markwmuller
I would strongly caution against installing something from a website that doesn't even have HTTPS set up
It's unlikely anyone has a MITM attack server on people's routes but, yes, HTTPS would be better.
the dev claims they don't have github access (from a github account -- what access is lacking?
They're talking about write access on the existing repository.
It's still wise to exercise caution, but remember that .xpi files are just zip archives, and all source on an extension can be inspected.
@rzroth We appreciate your work, but could you please fork the repo on Github, commit the changes to your fork, then open a pull request? Then everyone can see what's changed and why.
Super! Installs well on Win10Pro TB68.8.1 .. but layout needs optimisation. It seems to consist of wo fields .. the left one works .. the right on (which shouldn't be there) doesn't.
Edit: No change after updating to TB68.9.0
Instead of complaining I created a PR (#93) with @rzroth's commit and set him as author, please feel free to review it.
@rzroth: I will close my pull request if you create one. If you are unsure how there is a short documentation , e.g. here: https://opensource.com/article/19/7/create-pull-request-github
Thanks alot for your efforts. Hope you will maintain a fork of this great add-on!
@rzroth: thanks for the patch @riedel: what do I have to install it? Just download the fork as a zip and rename this .zip to .xpi ?
Works for me, thank you @rzroth @riedel ! How to install, @fpierrat , follow these instructions https://stackoverflow.com/questions/19240653/how-to-create-xpi-file-with-7zip (I just zipped from linux file browser, renamed to .xpi, and could open it. Note the folder structure seems to matter)
Installed. Happy :-D Just this second input field mentioned by daniel-lo above. Looks a bit strange, but it doesn't seem to affect the searches... when you type them in the left input ;-)
I've tried to install it (both @rzroth xpi than following instructions reporte by @markwmuller), but it's saying that is non compatible with TB 68.10. Any suggestion?
The manifest.json is too strict, change to: "strict_max_version": "68.*" and it works fine.
I'll upload the git/xpi file later today
Does anyone have guidelines as to how strict the settings should be ??
On 7/2/2020 5:20 AM, gsappa wrote:
I've tried to install it (both @rzroth https://github.com/rzroth xpi than following instructions reporte by @markwmuller https://github.com/markwmuller), but it's saying that is non compatible with TB 68.10. Any suggestion?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/wangvisual/expression-search/issues/92#issuecomment-652893449, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTLXVBOFURRDKSAPG775ATRZRGMHANCNFSM4NOILJXQ.
-- Rich Roth CEO TnR Global
Bio and personal blog: http://rizbang.com Building the really big sites: http://www.tnrglobal.com Small/Soho business in the PV: http://www.hidden-tech.net Places to meet for business: http://www.meetmewhere.com And for relaxation: http://www.welovemuseums.com http://www.artonmytv.com/ Helping move the world: http://www.earththrives.com
I changed the manifest.json like this, and it works fine. It is ok without "strict_max_version". There were other addons that didn't have "strict_max_version" either.
The manifest.json
"applications": { "gecko": { "id": "{03EF8A6E-C972-488f-92FA-98ABC2C9F8B9}", "strict_min_version": "68.0" } },
Hi all.
Thanks @riedel and @rzroth .
Disclaimer: Not a coder. Never used github to pull, fork or anything else code-related. Help gratefully received!
I tried the following, but so far nothing worked for me:
- Modifying the manifest.json in @rzroth 's original hack, re-zipping, re-naming to xpi, install from file in thunderbird. I tried both the editing of the max_version to 68.*, and the removal of this line as per @TNknKde1201 's comment.
- Downloading the files from here, unzipping (just to be sure), then re-zipping (with no top-level extension name folder), rename xpi, etc.
I keep getting the message that the add-on cannot be installed as it is incompatible with t-bird 68.10.0 (64).
Does anyone have any suggestions on what might be wrong, or what else I could try?
I really need this extension for my daily work... It stopped working again on TB 68.11.0... Please help... I cannot understand why this is not part of core TB...
Does anyone have any suggestions on what might be wrong, or what else I could try? Note: Fixed thanks to this: https://github.com/wangvisual/expression-search/issues/94#issuecomment-657239549
I really need this extension for my daily work... It stopped working again on TB 68.11.0... Please help... I cannot understand why this is not part of core TB...
Check here: https://github.com/wangvisual/expression-search/issues/95
The best solution will be a native TB support, please add your vote here https://bugzilla.mozilla.org/show_bug.cgi?id=538821
