sortedset icon indicating copy to clipboard operation
sortedset copied to clipboard

Published 20 hours ago • verified publisher icon wangjia184

Add Remove Option in `GetByScoreRangeOptions`

Open parkerroan opened this issue 3 years ago • 5 comments

This is a feature request to add a remove option to the options struct for GetByScoreRange. I have a branch and test case written, @wangjia184 could I have write access to push my branch and open a PR?

The use case is to "Pop" a range of scores without another iteration using Remove. I would like to use sortedset to delay values to a unix timestamp in the future(now + buffer). Then use GetByScoreRange to retrieve the items that are in the past like a queue. It will allow me to buffer messages and agg duplicates by key before publishing them.

parkerroan avatar Feb 07 '22 04:02 parkerroan

Hello @parkerroan
PR is welcome, could you please raise an PR?

wangjia184 avatar Feb 07 '22 10:02 wangjia184

@wangjia184 please invite me as a collaborator and I will push the branch up and open a PR. I don't think I am able to without that.

ERROR: Permission to wangjia184/sortedset.git denied to parkerroan.
fatal: Could not read from remote repository.

parkerroan avatar Feb 07 '22 15:02 parkerroan

@parkerroan you need create your own repository by folking this one, then apply changes in your branch, and raise a PR from your branch to this one. Everyone can create a PR from their own branch.

wangjia184 avatar Feb 08 '22 04:02 wangjia184

Sorry about that. Just opened the PR

parkerroan avatar Feb 08 '22 05:02 parkerroan

@wangjia184 https://github.com/wangjia184/sortedset/pull/13#issuecomment-1033783109

parkerroan avatar Feb 09 '22 16:02 parkerroan