code-review icon indicating copy to clipboard operation
code-review copied to clipboard

More context

Open agzam opened this issue 3 years ago • 3 comments

Sometimes, looking at a diff hunk, you wish there's more context around the change. Magit has magit-diff-more-context, and GitHub too - has a way of expanding a section. I wonder how difficult would it be to implement something like that in code-review? I guess it would require a custom-tailored GraphQL query and then some magic to update only the section at point.

agzam avatar Nov 30 '21 16:11 agzam

Alternatively it'd be nice to just be able to jump to a buffer with the full file?

draxil avatar Aug 26 '22 13:08 draxil

@draxil if I'm not mistaken you can already do this by hitting return with point on the diff of the file you want to jump to.

johnhamelink avatar Aug 26 '22 19:08 johnhamelink

@draxil if I'm not mistaken you can already do this by hitting return with point on the diff of the file you want to jump to.

For me, hitting return opens a new buffer to start writing a comment, but C-RET actually does the trick, is bound to magit-diff-visit-worktree-file, there are other versions of these functions to visit the file in another window/frame/worktree.

Regardless, would be great to expand the diff hunk adding more lines to it, maybe I just want to see a few lines more and not have to open the whole file; whatever the use-case, this is Emacs so users should have the ability to do this 🙃.

zzantares avatar Dec 02 '23 22:12 zzantares