code-review icon indicating copy to clipboard operation
code-review copied to clipboard

can't add comment to PR

Open emacsbliss opened this issue 2 years ago • 6 comments

Describe the bug Got error:

eieio-oset--closql-oset: Wrong type argument: eieio-object, nil, obj

when trying to add single comment to PR

To Reproduce Steps to reproduce the behavior:

  1. M-x code-review-start, enter PR url
  2. in Code Review buffer, press r then s c
  3. in the Code Review Comment buffer, typed comment, press C-c C-c got error

If I type r followed by c, then will get this error instead:

Errors: "Unprocessable Entity. You need to leave a comment indicating the requested changes."

Expected behavior A comment should be sent to the PR

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: MacOS
  • Browser Chrome
  • Version Emacs 28

Additional context I'm using enterprise github

emacsbliss avatar Mar 24 '22 22:03 emacsbliss

This might be related to a bug I noticed that seemed to be because of either large sized comments with lots of code blocks and/or special characters.

codygman avatar Mar 31 '22 22:03 codygman

I experience the same issue - I get the respective error messages in each of the two cases. How can I help trace the cause?

okybr avatar Apr 28 '22 08:04 okybr

same issue here. Can reproduce on a public repo if needed, happy to join debugging efforts.

klochowicz avatar Apr 28 '22 09:04 klochowicz

Getting this too. Has anyone had it work in some cases but not others? Example repos where it does and does not work would be helpful.

short-king avatar Nov 05 '22 17:11 short-king

also hitting the same behavior

z80dev avatar Dec 13 '23 21:12 z80dev