code-review icon indicating copy to clipboard operation
code-review copied to clipboard

`magit-section-toggle` inconsistent when looking at file diffs

Open rschmukler opened this issue 3 years ago • 1 comments
trafficstars

Describe the bug When using magit-section-toggle on a header under the files changed section, behavior can be inconsistent. Sometimes nothing happens (but then works if you run magit-section-toggle again), other times the wrong section toggles, or content expands above the active section. Sometimes subsections are not hidden. It seems like there could be an index error.

To Reproduce Visit a pull request with many diffs and changed files, then run magit-section-toggle and notice how behavior can be inconsistent.

Expected behavior Magit section toggle should work as reliably as in magit itself.

Screenshots Attached find a gif screencast. Note that I'm basically just moving the cursor around and running magit-section-toggle but you will see that behavior is somewhat inconsistent. This was done on https://github.com/clj-kondo/clj-kondo as an example.

output-2022-02-03-17:18:06

rschmukler avatar Feb 03 '22 23:02 rschmukler

Upon further digging this may be a duplicate of #152

rschmukler avatar Feb 03 '22 23:02 rschmukler