code-review icon indicating copy to clipboard operation
code-review copied to clipboard

Expanding headlines sometimes broken

Open fuzzycode opened this issue 3 years ago • 3 comments

Describe the bug Under some circumstances, TAB will not expand a collapsed heading.

To Reproduce Steps to reproduce the behavior:

  1. Collapse all headings
  2. With Point on "Files Changed" press TAB
  3. Go to one of the collapsed headings, not Commits
  4. Press TAB, heading will most likely not expand

If you go to "Commits" and expand it, it appears to resolve the issue and expanding and collapsing with TAB now works as expected again.

It appears a bit random what headings are affected from Point 2, some times one will work and other times it will be broken. I have not been able to find any logic or pattern in how this bug is working. The only persistent pattern is that TAB on "Commits" will always work as far as I can tell.

Expected behavior TAB Always expand/collapse a heading

fuzzycode avatar Dec 18 '21 19:12 fuzzycode

Note: this usually happens when the point is at the beginning of the line. If the point is moved one to the right, it works just fine.

Context: I use evil. No idea if that's relevant.

Stebalien avatar Dec 21 '21 23:12 Stebalien

I see an error with the Files changed section, the diff files should be under this section, so closing the Files changed section should collapse the modified files in this screenshot.

Screen Shot 2021-12-21 at 9 02 57 PM

But I still could not reproduce the issue here, could you post a giff of this issue?

wandersoncferreira avatar Dec 22 '21 00:12 wandersoncferreira

There is a gif in the #159 about the fix in Files Changed section. I don't think this is actually the root source of the issue here but would be great to have a gif like that one showing the problem.

wandersoncferreira avatar Dec 22 '21 00:12 wandersoncferreira