weave icon indicating copy to clipboard operation
weave copied to clipboard
verified publisher icon wandb

chore(ui): Feedback / annotations - trace view update

Open m-rgba opened this issue 9 months ago • 8 comments

Description

Before After
image image
  • Dead space for Feedback area: adds callouts to use different feedback mechanisms.
  • Added empty state for onboarding new annotations.
    • Added controls for creating Annotations (fields) from the trace view.
    • Added control for linking to Scorers for updating Annotations.
    • Added explicit close button for Annotation sidebar.
  • Created a new Annotation sidebar.
    • Later PR (4089) will split out the Scorer creation drawer from the Annotation creation drawer.
  • Changed button placement - added near other comment / reaction / notes items.
  • Smaller header (similar to trace tree) - added close control.
  • Added button controls for managing Annotation fields / adding a new field.
  • Styling updates.

m-rgba avatar Mar 24 '25 23:03 m-rgba

Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=a94976f11a322eb562e685152017d22853299340

circle-job-mirror[bot] avatar Mar 24 '25 23:03 circle-job-mirror[bot]

https://beta.wandb.ai/?betaVersion=4d59088fda403e7c41ed4ce01b2f73ed381fa6d0

m-rgba avatar Mar 25 '25 12:03 m-rgba

Updated Featurebee: https://beta.wandb.ai/?betaVersion=51f40d71ffd3a318c80a551a2fc15ca094a05922

m-rgba avatar Apr 08 '25 17:04 m-rgba

Updated Featurebee: https://beta.wandb.ai/?betaVersion=97dfeb8939454153248abb29e993315306ebe4fc

m-rgba avatar Apr 08 '25 20:04 m-rgba

https://beta.wandb.ai/?betaVersion=2203093a72698dbe99d2cc2ff8f6e9aebc7ea446

m-rgba avatar Apr 09 '25 16:04 m-rgba

Updated: https://beta.wandb.ai/?betaVersion=e698348644b457bdc22d150b1993aa5da97d2fe8

m-rgba avatar Apr 10 '25 15:04 m-rgba

Looks like there are a few issues preventing this PR from being merged!

  • GitHub Actions are failing:
    • test

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #3949

Feel free to include any additional details that might help me get this PR into a better state.

openhands-ai[bot] avatar Apr 11 '25 14:04 openhands-ai[bot]

Hey @m-rgba thank you for following up my comments! I also replied again.

I just realized that there are places that you are simply carrying over the old code. It is really awesome of you that you still dig into improving them as needed. For that I really appreciate it.

If needed, feel free to grab me to chat to quickly facilitate PR reviews.

chance-wnb avatar Apr 11 '25 19:04 chance-wnb