weave icon indicating copy to clipboard operation
weave copied to clipboard

BUG: Opening Evaluation.evaluate tab triggers error in UI

Open nthomsencph opened this issue 9 months ago • 4 comments

I keep getting this error when I select an Evaluation (Evaluation.evaluate) - Happens most times, not every time.

image

Happens here: https://wandb.ai/cbs-nlp/llama-7b-chat_center_embed_tn1_ce-lvl1_n5_tn0_i1/weave/calls?filter=%7B%22frozen%22%3Atrue%2C%22opVersionRefs%22%3A%5B%22weave%3A%2F%2F%2Fcbs-nlp%2Fllama-7b-chat_center_embed_tn1_ce-lvl1_n5_tn0_i1%2Fop%2FEvaluation.evaluate%3A*%22%5D%7D&peekPath=%2Fcbs-nlp%2Fllama-7b-chat_center_embed_tn1_ce-lvl1_n5_tn0_i1%2Fcalls%2F75ac49c6-64c3-4a79-8ed7-a649c6b22be9

Stacktrace (Chrome) image

nthomsencph avatar May 08 '24 12:05 nthomsencph

Hi @nthomsencph, sorry about error and thank you for sending in a bug report and a project with that repro, I will file an internal ticket and someone will hop on that as soon as possible. https://wandb.atlassian.net/browse/WB-18743

jwlee64 avatar May 10 '24 16:05 jwlee64

Thank you again for the detailed error report. This error is occurring because of the '/' character being used in object names, which is causing problems in parts of our code that use that as a delimiter. If possible I would recommend avoiding any special characters like that. Letters, numbers, dashes, and underscores should continue to be safe. We do intend to introduce more strict limitations on names.

We've deployed a fix that should prevent the URL you linked from crashing in that way, but I believe you are likely to encounter other problems with objects named like this until we can do a more comprehensive fix.

jamie-rasmussen avatar May 16 '24 15:05 jamie-rasmussen

Confirming that the initial fix from Jamie does allow the page to render, but these names are not handled properly in all cases. @nthomsencph we will be putting in place backend checks to stop such names in the future, so it is advised to change the names now if possible.

tssweeney avatar May 20 '24 19:05 tssweeney

Thanks for the clarification and swift action!

nthomsencph avatar May 20 '24 21:05 nthomsencph