wandb icon indicating copy to clipboard operation
wandb copied to clipboard

fix(sdk): fix console logging resumption, avoid overwrite

Open kptkin opened this issue 2 years ago • 1 comments

Description

  • Fixes WB-8698, WB-12526

This PR fixes a resume case where we would ignore the offset of the already streamed console lines. With the fix we always start from the provided offset.

Testing

This was tested manually and the goal is not to break the existing functionality of a single run. Based on the code it should be fine as by default the offset is 0.

kptkin avatar Feb 07 '24 01:02 kptkin

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dc63a74) 79.64% compared to head (5f40abb) 79.68%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6963      +/-   ##
==========================================
+ Coverage   79.64%   79.68%   +0.03%     
==========================================
  Files         462      462              
  Lines       52760    52760              
==========================================
+ Hits        42021    42042      +21     
+ Misses      10441    10420      -21     
  Partials      298      298              
Flag Coverage Δ
func 48.72% <ø> (+0.14%) :arrow_up:
system 61.93% <ø> (-0.01%) :arrow_down:
unit 59.20% <ø> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
wandb/sdk/internal/file_stream.py 88.41% <ø> (ø)

... and 8 files with indirect coverage changes

codecov[bot] avatar Feb 07 '24 02:02 codecov[bot]