wandb
wandb copied to clipboard
fix(sdk): fix console logging resumption, avoid overwrite
Description
- Fixes WB-8698, WB-12526
This PR fixes a resume case where we would ignore the offset of the already streamed console lines. With the fix we always start from the provided offset.
Testing
This was tested manually and the goal is not to break the existing functionality of a single run. Based on the code it should be fine as by default the offset is 0.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
dc63a74) 79.64% compared to head (5f40abb) 79.68%.
Additional details and impacted files
@@ Coverage Diff @@
## main #6963 +/- ##
==========================================
+ Coverage 79.64% 79.68% +0.03%
==========================================
Files 462 462
Lines 52760 52760
==========================================
+ Hits 42021 42042 +21
+ Misses 10441 10420 -21
Partials 298 298
| Flag | Coverage Δ | |
|---|---|---|
| func | 48.72% <ø> (+0.14%) |
:arrow_up: |
| system | 61.93% <ø> (-0.01%) |
:arrow_down: |
| unit | 59.20% <ø> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files | Coverage Δ | |
|---|---|---|
| wandb/sdk/internal/file_stream.py | 88.41% <ø> (ø) |