wandb icon indicating copy to clipboard operation
wandb copied to clipboard

fix(core): pass back the error from the server

Open kptkin opened this issue 2 years ago • 2 comments

Fixes

  • Fixes WB-17252
  • Fixes WB-17253
  • Fixes WB-17256

Description

What does the PR do?

Include a concise description of the PR contents

Testing

How was this PR tested?

TODO:

  • [ ] Write test for tag issue
  • [ ] ...

kptkin avatar Feb 04 '24 03:02 kptkin

@thanos-wandb great test cases i fix some of the tags bugs, but i'm not sure about the long list of tags. It seems to work for me although i agree the empty lines need to be fixed.

kptkin avatar Feb 04 '24 04:02 kptkin

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (f9e0059) 78.85% compared to head (ef930e5) 77.45%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6944      +/-   ##
==========================================
- Coverage   78.85%   77.45%   -1.40%     
==========================================
  Files         462      462              
  Lines       52740    52751      +11     
==========================================
- Hits        41589    40860     -729     
- Misses      10853    11593     +740     
  Partials      298      298              
Flag Coverage Δ
func 47.68% <ø> (-1.05%) :arrow_down:
system 59.68% <43.75%> (-0.80%) :arrow_down:
unit 59.08% <62.50%> (-0.13%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/pkg/server/sender.go 83.12% <100.00%> (-0.23%) :arrow_down:
core/internal/clients/retry_policy.go 82.50% <71.42%> (-8.68%) :arrow_down:

... and 71 files with indirect coverage changes

codecov[bot] avatar Feb 04 '24 04:02 codecov[bot]