wandb
wandb copied to clipboard
fix(sdk): support console redirect mode in wandb service
Fixes WB-NNNN Fixes #NNNN
copilot: all
Description
TODO:
- [ ] Debug and fix system test failures
- [ ] Warn users if settings.console changes between wrap and redir, you only get to choose one at first setup() time
- [ ] Figure out what to do with file output
- [ ] Fix circular import with console enum
- [ ] Add some fun mp tests
- [ ] Add some performance tests
- [ ] Possibly clean up emulator flush
Make sure this fixes:
- https://github.com/wandb/wandb/issues/4990
Testing
How was this PR tested?
Checklist
- Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)
Codecov Report
Attention: Patch coverage is 42.06897% with 84 lines in your changes are missing coverage. Please review.
Project coverage is 83.60%. Comparing base (
b18edd7) to head (7f97cb4). Report is 1115 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #3671 +/- ##
==========================================
- Coverage 83.91% 83.60% -0.32%
==========================================
Files 287 287
Lines 36513 36656 +143
==========================================
+ Hits 30640 30645 +5
- Misses 5873 6011 +138
| Flag | Coverage Δ | |
|---|---|---|
| functest | 56.79% <42.06%> (-0.04%) |
:arrow_down: |
| unittest | 73.80% <34.48%> (-0.50%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files | Coverage Δ | |
|---|---|---|
| wandb/sdk/service/service_base.py | 93.54% <ø> (ø) |
|
| wandb/sdk/service/service_grpc.py | 88.67% <50.00%> (-4.94%) |
:arrow_down: |
| wandb/sdk/wandb_run.py | 90.73% <58.33%> (-0.23%) |
:arrow_down: |
| wandb/sdk/lib/sock_client.py | 90.25% <0.00%> (-3.93%) |
:arrow_down: |
| wandb/sdk/lib/redirect.py | 83.02% <63.15%> (-3.44%) |
:arrow_down: |
| wandb/sdk/service/service_sock.py | 83.92% <25.00%> (-16.08%) |
:arrow_down: |
| wandb/sdk/wandb_manager.py | 81.38% <52.83%> (-11.27%) |
:arrow_down: |
| wandb/sdk/service/server_sock.py | 79.91% <21.62%> (-11.00%) |
:arrow_down: |
Consider solving the issue raised in this PR: https://github.com/wandb/wandb/pull/4603
with a explicit console log of the traceback