chrono icon indicating copy to clipboard operation
chrono copied to clipboard

Main branch failing test.

Open HendrikJan opened this issue 2 years ago • 3 comments

Hi,

I'm trying to create a PR for a minor improvement for the Dutch language.

Unfortunately I cannot create a commit because Husky won't let me. Husky won't let me because the test "Compare with native js" fails.

Should I wait for a fix for this test before creating a PR?

Kind regards, Hendrik Jan

HendrikJan avatar Nov 13 '23 09:11 HendrikJan

I've now created a PR using "--no-verify", but questing remains if I should wait for the test to pass.

HendrikJan avatar Nov 13 '23 09:11 HendrikJan

Hello @HendrikJan.

Could you share more specific details about the cases that are failing? or what error message do you get?

wanasit avatar Nov 19 '23 02:11 wanasit

The error I get is this: image

Since you already accepted my PR this failing test is not blocking me anymore (therefore I updated the title of this issue).

HendrikJan avatar Nov 20 '23 08:11 HendrikJan