chrono
chrono copied to clipboard
wanasit
Added Italian Locale
Hello @ntotao. Thanks for your contribution!! I will try to complete reviewing you change as soon as possible, but there is an obvious feedback I'd like to ask.
Could you also include the tests for the new locale?
The tests are as important if not more important than the parsers. Only with the tests, we can keep the parsers work both for now and in the future. Imagine, if I or other contributors who don't speak Italian trying to refactor or making change to Chrono, we would never know if it works correctly for Italian without your tests.
I can add tests if needed, could you please tell me which one should I translate from English? I've seen not every language have the same amount of files as English.
Thanks.
@federicodilo Thanks for looking. Sorry for my slow reply.
As you see, tests for different locales are not equally comprehensive. But, in general, the more tests the better.
The tests with the highest priorities (high ROI) are probably:
- The locale general test (e.g.
en.test.ts) with commonly used and pitfall - If timing expression is difficult in IT, you may want to add time-specific tests (e.g.
en_time_exp.test.ts) - The relative time (e.g. time unit or time ago) is different from the normal date/time. We should also test those (if the locale supports relative time expression) e.g.
en_time_units_ago.test.ts
You also do not need to copy and translate English. It is simply a good place to start, but do whatever input and expected output make sense in the locale.
