YouTubeAdAway icon indicating copy to clipboard operation
YouTubeAdAway copied to clipboard

Fix for new youtube version

Open ChristophPech opened this issue 6 years ago • 39 comments

ChristophPech avatar Aug 30 '18 12:08 ChristophPech

Wow nice, could you release an APK meanwhile?

minhng99 avatar Aug 31 '18 14:08 minhng99

I just released an update, but not based on Christoph patch, i still need more time to test some of his refactoring changes.

wanam avatar Aug 31 '18 15:08 wanam

One main change is that I am going over all obfuscated classes in the package instead of trying all three letter combinations because they also use four letter classes. The obfuscator might use these one day. Then I am changing the value of the timestamp in beforehook instead of after so I don't need to touch the member variable. While testing it I found out some if the long values are timestamps in milliseconds but some seem to be durations or at least relative values so I set them to zero, but a large value number works as well.

ChristophPech avatar Aug 31 '18 15:08 ChristophPech

I'm still randomly seeing ads when video started with the Wanam's version, also YouTube has crashed once when the video is playing.

There's nothing interesting in the xposed log so I didn't bother...

-------- Original Message -------- On Aug 31, 2018, 10:48 PM, Christoph Pech wrote:

One main change is that I am going over all obfuscated classes in the package instead of trying all three letter combinations because they also use four letter classes. The obfuscator might use these one day. Then I am changing the value of the timestamp in beforehook instead of after so I don't need to touch the member variable. While testing it I found out some if the long values are timestamps in milliseconds but some seem to be durations or at least relative values so I set them to zero, but a large value number works as well.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

minhng99 avatar Aug 31 '18 16:08 minhng99

I have tried this one and the last update wanam provided. This one works just fine, haven't had much testing tho , loaded 10 videos+ and haven't got any ad yet besides the main screen where you have an ad video but I don't really mind that

Wanam's version doesn't work for me (using Pixel 2 XL, Android 8.1) Thanks for the contribution :)

Aviv258958 avatar Aug 31 '18 23:08 Aviv258958

i've compiled the PR from @ChristophPech and it's working really good, thanks! There's not even ads in the video, I'll leave the apk file here: https://drive.google.com/open?id=1PRreR2cBpdt08T0-aTx_1us_CSb5OQxd

minhng99 avatar Sep 23 '18 04:09 minhng99

i've compiled the PR from @ChristophPech and it's working really good, thanks! There's not even ads in the video, I'll leave the apk file here: https://drive.google.com/open?id=1PRreR2cBpdt08T0-aTx_1us_CSb5OQxd

thanks for compile, package installer tells me APK file is corrupt Android 7.1.2

street-grease-coder avatar Sep 23 '18 09:09 street-grease-coder

I installed it successfully, make sure you removed the old one first because signature won't match

minhng99 avatar Sep 23 '18 09:09 minhng99

mea culpa, indeed the solution was this simple. I do still see videos at the beginning, but I imagine this might be due to cache files

street-grease-coder avatar Sep 23 '18 10:09 street-grease-coder

@ChristophPech ads has appeared again in version 13.37.52, could you please check?

minhng99 avatar Sep 25 '18 15:09 minhng99

@SandPox it should work now again

ChristophPech avatar Sep 26 '18 09:09 ChristophPech

yes, it's working now, if anyone want the prebuilt apk: https://drive.google.com/open?id=1kDBQq7FMIUThD-C1jWI2kjkF8hMYW7rl

uninstall the previous version first if install failed

updated to eeafb5a5e391157bf3a5b0bdd48af132a271f36a

minhng99 avatar Sep 26 '18 10:09 minhng99

I made the app save the "obfuscation detection" results since they only change on new YT versions. So on the first start it detects the classes and reuses these results on all subsequent starts. Since the detection itself is somehow triggering these #60 problems, this caching I added will help there too. On Android #60 happens only sometimes, but on 8.1 it happens all the time.

ChristophPech avatar Sep 28 '18 08:09 ChristophPech

@wanam the official release is not working since 2 months. I'm using this patch, but this should be mainstream so all of us could update with xposed updater.

ngosang avatar Sep 30 '18 09:09 ngosang

Can confirm on Android 7.1 and latest Xposed, official 4.3.3 doesn't hide ads at the beginning of videos with YT 13.39.51. This PR fixed the issue

AuroraWright avatar Oct 08 '18 12:10 AuroraWright

Installed @SandPox shared apk. Android8.1 still crashes. YouTube Version 13.34.50. When I open the YouTube app, the home page is displayed, then the app crashes, every time it is like this

monkey000 avatar Oct 09 '18 01:10 monkey000

@monkey000 could you try clear data of youtube app? I'm using 6.0 and latest youtube version, there's no ads or crash here

minhng99 avatar Oct 09 '18 02:10 minhng99

@SandPox Tried to clear the data and still crash. Now I am using the YouTube Vanced module in the Magisk framework, and no ads will appear. Otherwise I will consider whether to open YouTube Premium.

monkey000 avatar Oct 09 '18 02:10 monkey000

The SandPox binary is from before my fix for 8.1

ChristophPech avatar Oct 09 '18 06:10 ChristophPech

Where's your fix for 8.1? Pretty sure I was complied your latest commit on your repo eeafb5a which is 12 days ago

minhng99 avatar Oct 09 '18 07:10 minhng99

Sorry, I didn't see you already updated it.

ChristophPech avatar Oct 09 '18 07:10 ChristophPech

@SandPox I am very sorry, it's my fault.I did not see the link you updated later. I downloaded and installed the first apk.

monkey000 avatar Oct 09 '18 07:10 monkey000

@ChristophPech the ads has come back, could you update it?

minhng99 avatar Oct 23 '18 17:10 minhng99

Which YouTube version? I don't see them on 13.41.53

AuroraWright avatar Oct 23 '18 19:10 AuroraWright

Yes it's that version, only ads in the beginning of the video in like... 3 days ago

minhng99 avatar Oct 23 '18 19:10 minhng99

I see adds too now on the latest version. Only in the starting though. Not in between the video.

rishav394 avatar Oct 31 '18 20:10 rishav394

I'm starting to see some ads between video now

minhng99 avatar Oct 31 '18 23:10 minhng99

Still nothing here on latest YouTube, are you sure you emptied the YouTube app's data after you installed this fork?

AuroraWright avatar Nov 04 '18 15:11 AuroraWright

Idk can't say anything for sure. Ads have stopped again. Huh. 🤔🤔 Also merge this PR pls ofc after resolving the conflicts.

rishav394 avatar Nov 06 '18 13:11 rishav394

Not working in last version :(

ngosang avatar Nov 18 '18 17:11 ngosang

It's stable for me, but some ads keep showing again

street-grease-coder avatar Nov 19 '18 02:11 street-grease-coder

It doesn't work on the latest version, any way to fix it? The ads are disturbing.

acsway878787 avatar Dec 21 '18 22:12 acsway878787

@ChristophPech Seems like the original author lost interest... Could you take care of this project or make a fork?

ngosang avatar Jan 01 '19 23:01 ngosang

@ngosang I don't have the time to continue this either.

ChristophPech avatar Jan 02 '19 10:01 ChristophPech

@ChristophPech Maybe you can give me some hint of maintaining this module then I can continue this project. It's really hard to figure out what to do with this only by viewing the codes...

acsway878787 avatar Jan 02 '19 11:01 acsway878787

@acsway878787 unfortunately this is how it was done all the time, you need to pinpoint some classes, and try to analyze them based on the json keys strings and logging messages.

wanam avatar Jan 02 '19 11:01 wanam

Try Youtube Vance, it's pretty good

minhng99 avatar Jan 02 '19 14:01 minhng99

@ngosang I don't have the time to continue this either.

I just lost my job and I have time to do this. try this: https://github.com/ohyeah521/NoAds-For-YouTube/releases

i had test on my phone, If there is a problem, please submit issues

ohyeah521 avatar May 11 '19 04:05 ohyeah521

Sorry, I'm using Youtube Vance now.

ngosang avatar May 11 '19 12:05 ngosang