460 element equality
Element now has __eq__ method that works with numpy array as well a is_close method that useful for approximate equality testing.
Codecov Report
:x: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 73.70%. Comparing base (6403619) to head (03222b3).
:warning: Report is 7 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| kwave/utils/kwave_array.py | 96.55% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #462 +/- ##
==========================================
+ Coverage 73.61% 73.70% +0.09%
==========================================
Files 50 50
Lines 6929 6953 +24
Branches 1315 1325 +10
==========================================
+ Hits 5101 5125 +24
Misses 1283 1283
Partials 545 545
| Flag | Coverage Δ | |
|---|---|---|
| 3.10 | 73.70% <96.55%> (+0.09%) |
:arrow_up: |
| 3.11 | 73.70% <96.55%> (+0.09%) |
:arrow_up: |
| 3.12 | 73.70% <96.55%> (+0.09%) |
:arrow_up: |
| 3.13 | 73.70% <96.55%> (+0.09%) |
:arrow_up: |
| macos-latest | 73.68% <96.55%> (+0.09%) |
:arrow_up: |
| ubuntu-latest | 73.68% <96.55%> (+0.09%) |
:arrow_up: |
| windows-latest | 73.69% <96.55%> (+0.09%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Hi @precicely,
thanks for the PR. It looks great. Before I review the PR, it would be great if you could extend the test coverage for the new functionality.
Thanks, Walter
No problem @waltsims. I've tweaked the code a bit and improved the coverage.
@precicely would you like to update this PR?
Hi @waltsims, sorry last few months have been madness for me but will get this sorted in the next couple days. Also, I'll be wearing my ultrasound hat a lot from now on, so please don't hesitate to give me some jobs!
Done.